Improve error handling in engine_api client using thiserror. Fixes #326

[zedddie]

Improve engine_api errors

Improve errors in engine_api #326

(this is my second time trying to contribute, feedback is welcome)

• run cargo fmt;
• run cargo clippy;
• run cargo testand all tests pass;
• linked to the originating issue (if applicable).

[banditopazzo]

Hey, thank you for your PR! 👋

In general, it's fine. I pointed out some small things that would be great if you could address before merging. Let me know if anything is unclear or if you need a hand with it—happy to help!

Thanks again for your contribution! 😊

[zedddie]

i hope i did requested changes well :p

[zedddie]

I removed everything you said, but have a problem, as I said earlier on line 260 events_stream is returning <Event, WebsocketError> so we cant convert Error to WebsocketError when there is no WebSocketConnectionError(which represent any WebsocketError (tokio_tungstenite::tungstenite::Error)) in our WebsocketError

[zedddie]

to delete WebsocketConnectionError I will need to change fn event_monitor to return Result<Event, EngineClientError>>, EngineClientError> instead of Result<Event, WebsocketError>>, EngineClientError>, which seems to be strange, and will require to move all WebsocketError enums into EngineClientError

[banditopazzo]

to delete WebsocketConnectionError I will need to change fn event_monitor to return Result<Event, EngineClientError>>, EngineClientError> instead of Result<Event, WebsocketError>>, EngineClientError>, which seems to be strange, and will require to move all WebsocketError enums into EngineClientError

right, never mind keep the code as it is

[banditopazzo]

please rebase also on main

[zedddie]

thanks for your guidance 😊