Skip to content

Conversation

@dixyes
Copy link

@dixyes dixyes commented Aug 24, 2025

Update cython dependency to support python 3.13

Description

  1. Update cython dependency
  2. It failed build, so I added noexcept annotation

not all deprecations and other warnings fixed, it only runs on 3.13

Types of change

bug fix? for compatibility

Checklist

  • I confirm that I have the right to submit this contribution under the project's MIT license.
  • I ran the tests, and all new and existing tests passed.
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

tests failed on local but seems not related / is deprecation

============================================== short test summary info ===============================================
FAILED thinc/tests/backends/test_ops.py::test_ops_consistency[NumpyOps] - AssertionError: alloc
FAILED thinc/tests/backends/test_ops.py::test_compare_activations_to_torch[torch_func0-float32-ops0] - DeprecationWarning: Conversion of an array with ndim > 0 to a scalar is deprecated, and will error in future. Ens...
FAILED thinc/tests/backends/test_ops.py::test_compare_activations_to_torch[torch_func0-float32-ops1] - DeprecationWarning: Conversion of an array with ndim > 0 to a scalar is deprecated, and will error in future. Ens...
FAILED thinc/tests/backends/test_ops.py::test_compare_activations_to_torch[torch_func0-float64-ops0] - DeprecationWarning: Conversion of an array with ndim > 0 to a scalar is deprecated, and will error in future. Ens...
FAILED thinc/tests/backends/test_ops.py::test_compare_activations_to_torch[torch_func0-float64-ops1] - DeprecationWarning: Conversion of an array with ndim > 0 to a scalar is deprecated, and will error in future. Ens...
FAILED thinc/tests/backends/test_ops.py::test_compare_activations_to_torch[torch_func1-float32-ops0] - DeprecationWarning: Conversion of an array with ndim > 0 to a scalar is deprecated, and will error in future. Ens...
FAILED thinc/tests/backends/test_ops.py::test_compare_activations_to_torch[torch_func1-float32-ops1] - DeprecationWarning: Conversion of an array with ndim > 0 to a scalar is deprecated, and will error in future. Ens...
FAILED thinc/tests/backends/test_ops.py::test_compare_activations_to_torch[torch_func1-float64-ops0] - DeprecationWarning: Conversion of an array with ndim > 0 to a scalar is deprecated, and will error in future. Ens...
FAILED thinc/tests/backends/test_ops.py::test_compare_activations_to_torch[torch_func1-float64-ops1] - DeprecationWarning: Conversion of an array with ndim > 0 to a scalar is deprecated, and will error in future. Ens...
FAILED thinc/tests/backends/test_ops.py::test_compare_activations_to_torch[torch_func2-float32-ops0] - DeprecationWarning: Conversion of an array with ndim > 0 to a scalar is deprecated, and will error in future. Ens...
FAILED thinc/tests/backends/test_ops.py::test_compare_activations_to_torch[torch_func2-float32-ops1] - DeprecationWarning: Conversion of an array with ndim > 0 to a scalar is deprecated, and will error in future. Ens...
FAILED thinc/tests/backends/test_ops.py::test_compare_activations_to_torch[torch_func2-float64-ops0] - DeprecationWarning: Conversion of an array with ndim > 0 to a scalar is deprecated, and will error in future. Ens...
FAILED thinc/tests/backends/test_ops.py::test_compare_activations_to_torch[torch_func2-float64-ops1] - DeprecationWarning: Conversion of an array with ndim > 0 to a scalar is deprecated, and will error in future. Ens...
FAILED thinc/tests/backends/test_ops.py::test_compare_activations_to_torch[torch_func3-float32-ops0] - DeprecationWarning: Conversion of an array with ndim > 0 to a scalar is deprecated, and will error in future. Ens...
FAILED thinc/tests/backends/test_ops.py::test_compare_activations_to_torch[torch_func3-float32-ops1] - DeprecationWarning: Conversion of an array with ndim > 0 to a scalar is deprecated, and will error in future. Ens...
FAILED thinc/tests/backends/test_ops.py::test_compare_activations_to_torch[torch_func3-float64-ops0] - DeprecationWarning: Conversion of an array with ndim > 0 to a scalar is deprecated, and will error in future. Ens...
FAILED thinc/tests/backends/test_ops.py::test_compare_activations_to_torch[torch_func3-float64-ops1] - DeprecationWarning: Conversion of an array with ndim > 0 to a scalar is deprecated, and will error in future. Ens...
FAILED thinc/tests/backends/test_ops.py::test_compare_activations_to_torch[torch_func4-float32-ops0] - DeprecationWarning: Conversion of an array with ndim > 0 to a scalar is deprecated, and will error in future. Ens...
FAILED thinc/tests/backends/test_ops.py::test_compare_activations_to_torch[torch_func4-float32-ops1] - DeprecationWarning: Conversion of an array with ndim > 0 to a scalar is deprecated, and will error in future. Ens...
FAILED thinc/tests/backends/test_ops.py::test_compare_activations_to_torch[torch_func4-float64-ops0] - DeprecationWarning: Conversion of an array with ndim > 0 to a scalar is deprecated, and will error in future. Ens...
FAILED thinc/tests/backends/test_ops.py::test_compare_activations_to_torch[torch_func4-float64-ops1] - DeprecationWarning: Conversion of an array with ndim > 0 to a scalar is deprecated, and will error in future. Ens...
FAILED thinc/tests/backends/test_ops.py::test_compare_activations_to_torch[torch_func5-float32-ops0] - DeprecationWarning: Conversion of an array with ndim > 0 to a scalar is deprecated, and will error in future. Ens...
FAILED thinc/tests/backends/test_ops.py::test_compare_activations_to_torch[torch_func5-float32-ops1] - DeprecationWarning: Conversion of an array with ndim > 0 to a scalar is deprecated, and will error in future. Ens...
FAILED thinc/tests/backends/test_ops.py::test_compare_activations_to_torch[torch_func5-float64-ops0] - DeprecationWarning: Conversion of an array with ndim > 0 to a scalar is deprecated, and will error in future. Ens...
FAILED thinc/tests/backends/test_ops.py::test_compare_activations_to_torch[torch_func5-float64-ops1] - DeprecationWarning: Conversion of an array with ndim > 0 to a scalar is deprecated, and will error in future. Ens...
FAILED thinc/tests/backends/test_ops.py::test_compare_activations_to_torch[torch_func6-float32-ops0] - DeprecationWarning: Conversion of an array with ndim > 0 to a scalar is deprecated, and will error in future. Ens...
FAILED thinc/tests/backends/test_ops.py::test_compare_activations_to_torch[torch_func6-float32-ops1] - DeprecationWarning: Conversion of an array with ndim > 0 to a scalar is deprecated, and will error in future. Ens...
FAILED thinc/tests/backends/test_ops.py::test_compare_activations_to_torch[torch_func6-float64-ops0] - DeprecationWarning: Conversion of an array with ndim > 0 to a scalar is deprecated, and will error in future. Ens...
FAILED thinc/tests/backends/test_ops.py::test_compare_activations_to_torch[torch_func6-float64-ops1] - DeprecationWarning: Conversion of an array with ndim > 0 to a scalar is deprecated, and will error in future. Ens...
FAILED thinc/tests/backends/test_ops.py::test_compare_activations_to_torch[torch_func7-float32-ops0] - DeprecationWarning: Conversion of an array with ndim > 0 to a scalar is deprecated, and will error in future. Ens...
FAILED thinc/tests/backends/test_ops.py::test_compare_activations_to_torch[torch_func7-float32-ops1] - DeprecationWarning: Conversion of an array with ndim > 0 to a scalar is deprecated, and will error in future. Ens...
FAILED thinc/tests/backends/test_ops.py::test_compare_activations_to_torch[torch_func7-float64-ops0] - DeprecationWarning: Conversion of an array with ndim > 0 to a scalar is deprecated, and will error in future. Ens...
FAILED thinc/tests/backends/test_ops.py::test_compare_activations_to_torch[torch_func7-float64-ops1] - DeprecationWarning: Conversion of an array with ndim > 0 to a scalar is deprecated, and will error in future. Ens...
FAILED thinc/tests/backends/test_ops.py::test_compare_activations_to_torch[torch_func8-float32-ops0] - DeprecationWarning: Conversion of an array with ndim > 0 to a scalar is deprecated, and will error in future. Ens...
FAILED thinc/tests/backends/test_ops.py::test_compare_activations_to_torch[torch_func8-float32-ops1] - DeprecationWarning: Conversion of an array with ndim > 0 to a scalar is deprecated, and will error in future. Ens...
FAILED thinc/tests/backends/test_ops.py::test_compare_activations_to_torch[torch_func8-float64-ops0] - DeprecationWarning: Conversion of an array with ndim > 0 to a scalar is deprecated, and will error in future. Ens...
FAILED thinc/tests/backends/test_ops.py::test_compare_activations_to_torch[torch_func8-float64-ops1] - DeprecationWarning: Conversion of an array with ndim > 0 to a scalar is deprecated, and will error in future. Ens...
FAILED thinc/tests/backends/test_ops.py::test_compare_activations_to_torch[torch_func9-float32-ops0] - DeprecationWarning: Conversion of an array with ndim > 0 to a scalar is deprecated, and will error in future. Ens...
FAILED thinc/tests/backends/test_ops.py::test_compare_activations_to_torch[torch_func9-float32-ops1] - DeprecationWarning: Conversion of an array with ndim > 0 to a scalar is deprecated, and will error in future. Ens...
FAILED thinc/tests/backends/test_ops.py::test_compare_activations_to_torch[torch_func9-float64-ops0] - DeprecationWarning: Conversion of an array with ndim > 0 to a scalar is deprecated, and will error in future. Ens...
FAILED thinc/tests/backends/test_ops.py::test_compare_activations_to_torch[torch_func9-float64-ops1] - DeprecationWarning: Conversion of an array with ndim > 0 to a scalar is deprecated, and will error in future. Ens...
FAILED thinc/tests/backends/test_ops.py::test_compare_activations_to_torch[torch_func10-float32-ops0] - DeprecationWarning: Conversion of an array with ndim > 0 to a scalar is deprecated, and will error in future. Ens...
FAILED thinc/tests/backends/test_ops.py::test_compare_activations_to_torch[torch_func10-float32-ops1] - DeprecationWarning: Conversion of an array with ndim > 0 to a scalar is deprecated, and will error in future. Ens...
FAILED thinc/tests/backends/test_ops.py::test_compare_activations_to_torch[torch_func10-float64-ops0] - DeprecationWarning: Conversion of an array with ndim > 0 to a scalar is deprecated, and will error in future. Ens...
FAILED thinc/tests/backends/test_ops.py::test_compare_activations_to_torch[torch_func10-float64-ops1] - DeprecationWarning: Conversion of an array with ndim > 0 to a scalar is deprecated, and will error in future. Ens...
FAILED thinc/tests/backends/test_ops.py::test_compare_activations_to_torch[torch_func11-float32-ops0] - DeprecationWarning: Conversion of an array with ndim > 0 to a scalar is deprecated, and will error in future. Ens...
FAILED thinc/tests/backends/test_ops.py::test_compare_activations_to_torch[torch_func11-float32-ops1] - DeprecationWarning: Conversion of an array with ndim > 0 to a scalar is deprecated, and will error in future. Ens...
FAILED thinc/tests/backends/test_ops.py::test_compare_activations_to_torch[torch_func11-float64-ops0] - DeprecationWarning: Conversion of an array with ndim > 0 to a scalar is deprecated, and will error in future. Ens...
FAILED thinc/tests/backends/test_ops.py::test_compare_activations_to_torch[torch_func11-float64-ops1] - DeprecationWarning: Conversion of an array with ndim > 0 to a scalar is deprecated, and will error in future. Ens...
FAILED thinc/tests/layers/test_layers_api.py::test_layers_from_config[SparseLinear.v1-kwargs55-in_data55-out_data55] - NameError: name 'InT' is not defined
FAILED thinc/tests/layers/test_layers_api.py::test_layers_from_config[SparseLinear.v2-kwargs56-in_data56-out_data56] - NameError: name 'InT' is not defined
FAILED thinc/tests/layers/test_layers_api.py::test_layers_from_config[premap_ids.v1-kwargs59-in_data59-out_data59] - NameError: name 'InT' is not defined
FAILED thinc/tests/layers/test_layers_api.py::test_dropout[data2] - thinc.util.DataValidationError: 
FAILED thinc/tests/layers/test_layers_api.py::test_layers_batching_all[premap_ids.v1-kwargs59-in_data59-out_data59] - NameError: name 'InT' is not defined
=============================== 54 failed, 1252 passed, 86 skipped in 71.37s (0:01:11) ===============================

@dixyes dixyes force-pushed the update-cython-to-support-3.13 branch from f274e7a to 8d1e889 Compare August 24, 2025 06:31
@cclauss
Copy link
Contributor

cclauss commented Aug 31, 2025

Nice! What about adding a similar PR for Python 4.14rc2?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants