[eas-cli] print the preview page link instead of the tunnel url - #4352
Open
gwdp wants to merge 2 commits into
Open
[eas-cli] print the preview page link instead of the tunnel url#4352gwdp wants to merge 2 commits into
gwdp wants to merge 2 commits into
Conversation
gwdp
force-pushed
the
gwdp/sim-preview-page-link
branch
3 times, most recently
from
September 4, 2026 23:38
c78e910 to
0391334
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## gwdp/build-tools-web-preview-page-log #4352 +/- ##
=========================================================================
+ Coverage 65.45% 65.52% +0.08%
=========================================================================
Files 1058 1058
Lines 49005 49018 +13
Branches 10424 10428 +4
=========================================================================
+ Hits 32070 32113 +43
+ Misses 15518 15489 -29
+ Partials 1417 1416 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
gwdp
force-pushed
the
gwdp/sim-preview-page-link
branch
from
September 4, 2026 23:52
0391334 to
a25626b
Compare
gwdp
changed the title
gwdp
force-pushed
the
gwdp/sim-preview-page-link
branch
from
September 5, 2026 01:02
9099374 to
0e0e5ad
Compare
gwdp
changed the base branch from
main
to
gwdp/build-tools-web-preview-page-log
September 5, 2026 01:02
The tunnel URL still works, so this is not a breaking change. Tests now cover the rewrite helpers end to end.
gwdp
force-pushed
the
gwdp/sim-preview-page-link
branch
from
September 5, 2026 01:07
0e0e5ad to
b4db19e
Compare
|
✅ Thank you for adding the changelog entry! |
gwdp
marked this pull request as ready for review
September 5, 2026 01:08
|
Subscribed to pull request
Generated by CodeMention Warning: The preamble and epilogue options in commentConfiguration are deprecated. Use template instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
We print the raw ngrok URL, so sharing it means the other person sees an ngrok error if the session is starting or gone.
How
Print the expo.dev preview page instead, in the instructions and in
--json. Falls back to the tunnel URL for a host the page cannot address.Test Plan
easd simulator:start..and confirm printed link