-
Notifications
You must be signed in to change notification settings - Fork 18
docs: add general labels documentation for issues and PRs #342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
cc: @expressjs/triagers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general this is GREAT. I added a few nitpick comments but will just drop an approval since I think they are easy to resolve.
docs/triage/labels.md
Outdated
| -------------------- | ----------------------------------------------------------------------------------- | | ||
| `bug` | Denotes confirmed bugs. | | ||
| `duplicate` | A duplicate issue. | | ||
| `enhancement` | An issue requesting an enhancement. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| `enhancement` | An issue requesting an enhancement. | | |
| `enhancement` | An issue requesting or implementing an enhancement. | |
docs/triage/labels.md
Outdated
| `bug` | Denotes confirmed bugs. | | ||
| `duplicate` | A duplicate issue. | | ||
| `enhancement` | An issue requesting an enhancement. | | ||
| `help wanted` | Extra help may be needed to resolve this issue. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| `help wanted` | Extra help may be needed to resolve this issue. | | |
| `help wanted` | Help from the community is requested to assist in resolving this issue. | |
docs/triage/labels.md
Outdated
| `enhancement` | An issue requesting an enhancement. | | ||
| `help wanted` | Extra help may be needed to resolve this issue. | | ||
| `invalid` | This is not a proper issue report, request, or question. | | ||
| `question` | For issues where the issuer is asking something. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have been moving these into discussions, which IMO is better than using a label. Could we just remove this?
Signed-off-by: Sebastian Beltran <[email protected]>
Signed-off-by: Sebastian Beltran <[email protected]>
Signed-off-by: Sebastian Beltran <[email protected]>
Signed-off-by: Sebastian Beltran <[email protected]>
- `needs triage`: This can be kept if the triager is unsure which next steps to take | ||
- `awaiting more info`: If more info has been requested from the author, apply this label. | ||
- `bug`: Issues that present a reasonable conviction there is a reproducible bug. | ||
- `enhancement`: Issues that are found to be a reasonable candidate feature additions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes were made by the linter
This was discussed in #294 about having the labels documented at the organizational level, so that new triagers know how to use them. Part of this was extracted from https://github.com/jshttp/style-guide?tab=readme-ov-file#issue-label-use.