Skip to content

feat: Moving types into the repo #6382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

feat: Moving types into the repo #6382

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
695f972
Moving types into the repo incl. their validation.
RobinTail Mar 9, 2025
fda6ec2
rm type for express.query (removed in 5.0.0-alpha.1)
RobinTail Mar 9, 2025
aa8bce7
Minor: removing tslint comment (no tslint).
RobinTail Mar 9, 2025
96bb4cd
Linting the type declaration files using typescript-eslint.
RobinTail Mar 9, 2025
5650890
Merge branch 'master' into mv-types
RobinTail Mar 9, 2025
c761007
Narrowing the extensions for ESLint config overrides.
RobinTail Mar 9, 2025
1e1c7e0
rm prettier directive
RobinTail Mar 20, 2025
cb1cb37
rm tripple slash directives and @types/* dependencies.
RobinTail Mar 20, 2025
76c2a36
Replacing DT internal link with an URL.
RobinTail Mar 20, 2025
e767f3a
feat: Testing the types (adjusted copy of the original assertions and…
RobinTail Mar 20, 2025
185f190
Adjusting expect-type methods (using shorthands and avoiding deprecat…
RobinTail Mar 20, 2025
7995e0e
Replacing ts-expect-error directive with expect-type assetions.
RobinTail Mar 20, 2025
bd14851
Assertions without negating the parameter type of res.json and res.send.
RobinTail Mar 20, 2025
3bbb1ca
Ref: rewriting test assignments into assertions.
RobinTail Mar 20, 2025
718f35b
Add missing semicolons
RobinTail Mar 21, 2025
559deba
Restoring tripple slash directives to keep the copy as is for now.
RobinTail Mar 21, 2025
e1c0aab
Minor grammar corrections and cleanup in test.
RobinTail Mar 21, 2025
96bedf5
Merge branch 'expressjs:master' into mv-types
RobinTail Apr 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .eslintrc.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,16 @@ root: true
env:
es2022: true
node: true
plugins:
- "@typescript-eslint"
rules:
eol-last: error
eqeqeq: [error, allow-null]
indent: [error, 2, { MemberExpression: "off", SwitchCase: 1 }]
no-trailing-spaces: error
no-unused-vars: [error, { vars: all, args: none, ignoreRestSiblings: true }]
overrides:
- files: ["*.ts"]
parser: "@typescript-eslint/parser"
rules:
no-unused-vars: off
3 changes: 3 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,9 @@ jobs:
path: ./coverage/lcov.info
retention-days: 1

- name: Test types
run: npm run test-types

coverage:
needs: test
runs-on: ubuntu-latest
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/legacy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,9 @@ jobs:
path: ./coverage/lcov.info
retention-days: 1

- name: Test types
run: npm run test-types

coverage:
needs: test
runs-on: ubuntu-latest
Expand Down
Loading