-
-
Notifications
You must be signed in to change notification settings - Fork 2k
feat: generate dynamic docs header links #2055
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ShubhamOulkar
wants to merge
15
commits into
expressjs:gh-pages
Choose a base branch
from
ShubhamOulkar:generate-header-links
base: gh-pages
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
0006a2e
add header links
ShubhamOulkar d6bbad9
fix redeclaration
ShubhamOulkar 7a564ea
fix design
ShubhamOulkar 8fd9b24
add margin and font size
ShubhamOulkar 9317fd8
change link content to hash
ShubhamOulkar 77deb08
remove outline and add color to hash
ShubhamOulkar 65b920f
Merge branch 'gh-pages' into generate-header-links
ShubhamOulkar 5ebee47
correct aria-label value
ShubhamOulkar 7498eb3
Scope header selection to main section
ShubhamOulkar 3e31697
add target highliting to header links
ShubhamOulkar 4e8a859
inherit color and font size from parent headers
ShubhamOulkar 2d3f972
expand link clickable area
ShubhamOulkar 081946a
Merge branch 'gh-pages' into generate-header-links
ShubhamOulkar 936bb85
Merge branch 'gh-pages' into generate-header-links
ShubhamOulkar 8333da5
add defensive check on heading
ShubhamOulkar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why is this new logic here instead of in app.js? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.