fix: use RFC 6265 path matching for cookie path option#1114
Open
UlisesGascon wants to merge 3 commits intomasterfrom
Open
fix: use RFC 6265 path matching for cookie path option#1114UlisesGascon wants to merge 3 commits intomasterfrom
UlisesGascon wants to merge 3 commits intomasterfrom
Conversation
|
Happy to help! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main Changes
/adminmatching/administrator)indexOfprefix check with segment-boundary-aware matchingcookie.pathsection of README, noting the change since 1.19.1 and the prior behaviorNotes
The previous implementation used
originalPath.indexOf(cookiePath) === 0which matched any path starting with the cookie path string, regardless of segment boundaries. Per RFC 6265 section 5.1.4, a cookie-path should only match if the request-path is identical, or the cookie-path is a prefix followed by a/character.This is a semver-patch change. It corrects a bug in path matching behavior without changing the public API. Applications using correctly segmented paths (e.g.,
/adminmatching/admin/users) are unaffected. Only the unintended matching of non-segment-boundary paths (e.g.,/adminmatching/administrator) is corrected.