Improve the error thrown when a bundle fails to load #51070
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D73925027 |
vzaidman
added a commit
to vzaidman/react-native
that referenced
this pull request
May 2, 2025
Summary: Changelog: [General][Internal][Breaking] When a bundle is failing to load throw an error of special type. Reviewed By: hoxyq Differential Revision: D73925027
|
This pull request was exported from Phabricator. Differential Revision: D73925027 |
vzaidman
added a commit
to vzaidman/react-native
that referenced
this pull request
May 9, 2025
Summary: Changelog: [General][Internal][Breaking] When a bundle is failing to load throw an error of special type. ### Breaking `didCompleteNetworkResponse` now throws an Error instead of throwing a string. In dev, we use [lazy bundling](https://github.com/react-native-community/discussions-and-proposals/blob/main/proposals/0605-lazy-bundling.md#__loadbundleasync-in-metro) which allows us to re-build only the parts of the app that are changed. However the function that loads these lazy bundles in `loadBundleFromServer.js` for requests that reach `didCompleteNetworkResponse` with an error **throws a string representing the error message** which makes debugging very inconvenient because it lacks stack trace and error type. Throwing strings is not a standard practice. We better throw an error in these cases so it can be handled better. Why a special type of error? * As you can see in the "after", in the test plan below, even with a stack trace, it might be hard to know where this error originates from * Also so extra information can be added on it. Currently adding "url" * Also to support error handling based on the type of error Differential Revision: D73925027
|
This pull request was exported from Phabricator. Differential Revision: D73925027 |
Summary: Changelog: [General][Internal][Breaking] When a bundle is failing to load throw an error of special type. ### Breaking `didCompleteNetworkResponse` now throws an Error instead of throwing a string. In dev, we use [lazy bundling](https://github.com/react-native-community/discussions-and-proposals/blob/main/proposals/0605-lazy-bundling.md#__loadbundleasync-in-metro) which allows us to re-build only the parts of the app that are changed. However the function that loads these lazy bundles in `loadBundleFromServer.js` for requests that reach `didCompleteNetworkResponse` with an error **throws a string representing the error message** which makes debugging very inconvenient because it lacks stack trace and error type. Throwing strings is not a standard practice. We better throw an error in these cases so it can be handled better. Why a special type of error? * As you can see in the "after", in the test plan below, even with a stack trace, it might be hard to know where this error originates from * Also so extra information can be added on it. Currently adding "url" * Also to support error handling based on the type of error Differential Revision: D73925027
|
This pull request was exported from Phabricator. Differential Revision: D73925027 |
|
This pull request has been merged in 0750b5f. |
|
This pull request was successfully merged by @vzaidman in 0750b5f When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Changelog: [General][Internal][Breaking] When a bundle is failing to load throw an error of special type.
Breaking
didCompleteNetworkResponsenow throws an Error instead of throwing a string.In dev, we use lazy bundling which allows us to re-build only the parts of the app that are changed.
However the function that loads these lazy bundles in
loadBundleFromServer.jsfor requests that reachdidCompleteNetworkResponsewith an error throws a string representing the error message which makes debugging very inconvenient because it lacks stack trace and error type. Throwing strings is not a standard practice. We better throw an error in these cases so it can be handled better.Why a special type of error?
Differential Revision: D73925027