Cleanup several warnings inside DisplayMetricsHolder #51074
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D74001269 |
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
May 13, 2025
Summary: While working on this class I noticed there are a number of warnings. Let's clean them up. Changelog: [Internal] [Changed] - Reviewed By: mdvacca Differential Revision: D74001269
cortinico
force-pushed
the
export-D74001269
branch
from
fda7cdd to
680700a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D74001269 |
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
May 13, 2025
Summary: Pull Request resolved: facebook#51074 While working on this class I noticed there are a number of warnings. Let's clean them up. Changelog: [Internal] [Changed] - Reviewed By: mdvacca Differential Revision: D74001269
cortinico
force-pushed
the
export-D74001269
branch
2 times, most recently
from
f256c67 to
2de4b9e
Compare
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
May 13, 2025
Summary: While working on this class I noticed there are a number of warnings. Let's clean them up. Changelog: [Internal] [Changed] - Reviewed By: mdvacca Differential Revision: D74001269
Summary: Pull Request resolved: facebook#51074 While working on this class I noticed there are a number of warnings. Let's clean them up. Changelog: [Internal] [Changed] - Reviewed By: mdvacca Differential Revision: D74001269
|
This pull request was exported from Phabricator. Differential Revision: D74001269 |
cortinico
force-pushed
the
export-D74001269
branch
from
2de4b9e to
14259a4
Compare
|
This pull request has been merged in 1d5bbf1. |
|
This pull request was successfully merged by @cortinico in 1d5bbf1 When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
While working on this class I noticed there are a number of warnings. Let's clean them up.
Changelog:
[Internal] [Changed] -
Reviewed By: mdvacca
Differential Revision: D74001269