Scaffold implementation and lifecycle #54245
Open
+132
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: # Changelog: [Internal] Just formatting. Differential Revision: D85266409
…ebook#54244) Summary: # Changelog: [Internal] Refactors the logic a bit, and adds `ReactNativeApplication` domain to the ones that are currently being tracked. We will use it as a signal for installation of `console.createTask()` implementation. Differential Revision: D85274860
Summary: # Changelog: [Internal] `RuntimeTarget` will have 2 new methods: - `stubConsoleCreateTask` - installs a `console.createTask` stub, so it is always available. - `installConsoleCreateTask` - installs the actual implementation, when there is a Fusebox client The implementation for these methods will be provided in a separate diff. Similarly, the lifecycle for installation / stub during the background tracing will be provided in a separate diff. Differential Revision: D85274859
meta-cla
bot
added
the
CLA Signed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
RuntimeTargetwill have 2 new methods:stubConsoleCreateTask- installs aconsole.createTaskstub, so it is always available.installConsoleCreateTask- installs the actual implementation, when there is a Fusebox clientThe implementation for these methods will be provided in a separate diff.
Similarly, the lifecycle for installation / stub during the background tracing will be provided in a separate diff.
Differential Revision: D85274859