Add missing RCT_REMOVE_LEGACY_COMPONENT_INTEROP guard to LegacyViewManagerInteropComponentDescriptor#57094
Closed
christophpurrer wants to merge 1 commit into
Closed
Conversation
…nagerInteropComponentDescriptor Summary: The iOS `LegacyViewManagerInteropComponentDescriptor.h` was missing the `RCT_REMOVE_LEGACY_COMPONENT_INTEROP` guard that the rest of the `legacyviewmanagerinterop` library already uses, so enabling that flag failed to compile. Add the guard for consistency. Changelog: [iOS][Fixed] - Add missing `RCT_REMOVE_LEGACY_COMPONENT_INTEROP` guard to `LegacyViewManagerInteropComponentDescriptor` Differential Revision: D107717474
meta-cla
Bot
added
the
CLA Signed
|
@christophpurrer has exported this pull request. If you are a Meta employee, you can view the originating Diff in D107717474. |
|
This pull request has been merged in 510cc0c. |
Collaborator
|
This pull request was successfully merged by @christophpurrer in 510cc0c When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The iOS
LegacyViewManagerInteropComponentDescriptor.hwas missing theRCT_REMOVE_LEGACY_COMPONENT_INTEROPguard that the rest of thelegacyviewmanagerinteroplibrary already uses, so enabling that flag failed to compile. Add the guard for consistency.Changelog: [iOS][Fixed] - Add missing
RCT_REMOVE_LEGACY_COMPONENT_INTEROPguard toLegacyViewManagerInteropComponentDescriptorDifferential Revision: D107717474