Skip to content

fix(iOS): release previous UIImage on source prop change to prevent memory leak (#12220) #57096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MuhammadSuleman97 wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −1
Open

fix(iOS): release previous UIImage on source prop change to prevent memory leak (#12220) #57096

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion packages/react-native/React/Fabric/Mounting/ComponentViews/Image/RCTImageComponentView.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,12 @@ - (void)_setStateAndResubscribeImageResponseObserver:(const ImageShadowNode::Con
observerCoordinator.removeObserver(_imageResponseObserverProxy);
}

// Release the previous image to prevent memory accumulation
// when the source prop changes rapidly (e.g., in animations/slideshows).
// The UIImageView retains the UIImage, preventing deallocation until
// the next image arrives, which can cause significant memory growth.
_imageView.image = nil;

_state = state;
Comment on lines +143 to 149

if (_state) {
Expand Down Expand Up @@ -301,4 +307,4 @@ - (void)didReceiveFailure:(NSError *)error fromObserver:(const void *)observer
Class<RCTComponentViewProtocol> RCTImageCls(void)
{
return RCTImageComponentView.class;
}
}
Loading