Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup enableObjectFiber experiment #32676

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

kassens
Copy link
Member

@kassens kassens commented Mar 19, 2025

We observed no signficant change in performance from this, so we can clean this up.

Keeping the class variant as that might give better values in memory profilers.

We observed no signficant change in performance from this, so we can clean this up.

Keeping the class variant as that might give better values in memory profilers.
@react-sizebot
Copy link

Comparing: a4842c9...23d42f2

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 517.29 kB 517.09 kB = 92.26 kB 92.23 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 608.06 kB 607.85 kB = 107.88 kB 107.85 kB
facebook-www/ReactDOM-prod.classic.js = 653.67 kB 652.99 kB = 115.18 kB 115.02 kB
facebook-www/ReactDOM-prod.modern.js = 643.95 kB 643.27 kB = 113.59 kB 113.43 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 23d42f2

Copy link
Member

@rickhanlonii rickhanlonii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah seeing FiberNode instead of JSObject in heap snapshots has been super handy.

@adiops-sh
Copy link

Looks good to me! Kassens

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants