Skip to content

Fix lazy thenable suspension race #35423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
leeguooooo wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix lazy thenable suspension race #35423

leeguooooo wants to merge 1 commit into from

Conversation

@leeguooooo
Copy link

@leeguooooo leeguooooo commented Dec 29, 2025

Summary

  • Track the thenable thrown by React.lazy with the same bookkeeping as use(), preventing short-lived promises from being missed.
  • Retry lazy initialization after instrumentation to resolve synchronously when possible.

How did you test this change?

  • yarn test ReactLazy-test.internal

Fixes #35399

@meta-cla meta-cla bot added the CLA Signed label Dec 29, 2025
@leeguooooo leeguooooo force-pushed the fix-35399-lazy-thenable-race branch from 3b3cfe6 to 46604ca Compare December 29, 2025 03:06
@leeguooooo leeguooooo marked this pull request as ready for review December 29, 2025 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug: resolveLazy catching promises causes race condition with short-lived Suspense-wrapped components

1 participant

@leeguooooo