Fix controlled select reset behavior after form action #35426
+91
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #30580
This PR fixes a bug where controlled
<select>elements were being incorrectly reset after form submission when using form actions, while controlled<input>elements correctly maintained their values.Problem
When a form with a controlled select element is submitted using a form action, React automatically calls
form.reset()after the action completes. According to the HTML specification:valueattribute (corresponding todefaultValueproperty)selectedattribute (corresponding todefaultSelectedproperty)React was syncing
defaultValuefor controlled inputs but not syncingdefaultSelectedfor controlled selects. This caused selects to reset to an undefined state rather than maintaining their controlled value.Solution
Modified three functions in
ReactDOMSelect.jsto sync thedefaultSelectedattribute for controlled select elements, making their behavior consistent with controlled inputs:initSelect()- line 155updateSelect()- line 224restoreControlledSelectState()- line 241Changed the
setDefaultSelectedparameter fromfalsetotruewhenvalue != null(controlled component).Test Plan
How to Test
Before fix: Select resets to first option after form submission
After fix: Select maintains the controlled value ✅