Skip to content

Dedupe effect dev warning #35427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Don-Erfano wants to merge 2 commits into
base: main
Choose a base branch
from
+30 −24
Open

Dedupe effect dev warning #35427

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b6896fe
Deduplicate DEV warning for missing effect callbacks
Don-Erfano Dec 30, 2025
6388cb1
Deduplicate DEV warning for missing effect callbacks
Don-Erfano Dec 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 30 additions & 24 deletions packages/react/src/ReactHooks.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,33 @@ function resolveDispatcher() {
return ((dispatcher: any): Dispatcher);
}

function warnOnMissingEffectCallback(
hookName: 'useEffect' | 'useInsertionEffect' | 'useLayoutEffect',
create: mixed,
): void {
if (__DEV__) {
if (create == null) {
switch (hookName) {
case 'useEffect':
console.warn(
'React Hook useEffect requires an effect callback. Did you forget to pass a callback to the hook?',
);
break;
case 'useInsertionEffect':
console.warn(
'React Hook useInsertionEffect requires an effect callback. Did you forget to pass a callback to the hook?',
);
break;
case 'useLayoutEffect':
console.warn(
'React Hook useLayoutEffect requires an effect callback. Did you forget to pass a callback to the hook?',
);
break;
}
}
}
}

export function getCacheForType<T>(resourceType: () => T): T {
const dispatcher = ReactSharedInternals.A;
if (!dispatcher) {
Expand Down Expand Up @@ -88,14 +115,7 @@ export function useEffect(
create: () => (() => void) | void,
deps: Array<mixed> | void | null,
): void {
if (__DEV__) {
if (create == null) {
console.warn(
'React Hook useEffect requires an effect callback. Did you forget to pass a callback to the hook?',
);
}
}

warnOnMissingEffectCallback('useEffect', create);
const dispatcher = resolveDispatcher();
return dispatcher.useEffect(create, deps);
}
Expand All @@ -104,14 +124,7 @@ export function useInsertionEffect(
create: () => (() => void) | void,
deps: Array<mixed> | void | null,
): void {
if (__DEV__) {
if (create == null) {
console.warn(
'React Hook useInsertionEffect requires an effect callback. Did you forget to pass a callback to the hook?',
);
}
}

warnOnMissingEffectCallback('useInsertionEffect', create);
const dispatcher = resolveDispatcher();
return dispatcher.useInsertionEffect(create, deps);
}
Expand All @@ -120,14 +133,7 @@ export function useLayoutEffect(
create: () => (() => void) | void,
deps: Array<mixed> | void | null,
): void {
if (__DEV__) {
if (create == null) {
console.warn(
'React Hook useLayoutEffect requires an effect callback. Did you forget to pass a callback to the hook?',
);
}
}

warnOnMissingEffectCallback('useLayoutEffect', create);
const dispatcher = resolveDispatcher();
return dispatcher.useLayoutEffect(create, deps);
}
Expand Down