Skip to content

Conversation

ben--
Copy link
Contributor

@ben-- ben-- commented Jul 1, 2025

Create the necessary buck config. Most of the config is adapted from folly's external configuration.

Test

This diff enables the following command to run:

~/oss/sapling$ buck2 targets eden/fs/service:
Build ID: 8f032f3a-d73a-424d-acca-7d85d340bd93
Command: targets.
Time elapsed: 0.0s
gh_facebook_sapling//eden/fs/service:edenfs
gh_facebook_sapling//eden/fs/service:edenfs-oss
gh_facebook_sapling//eden/fs/service:edenfs_privhelper
gh_facebook_sapling//eden/fs/service:edenfs_privhelper_with_setuid_root
gh_facebook_sapling//eden/fs/service:init
gh_facebook_sapling//eden/fs/service:java-swift-java11-thrift-dependencies
gh_facebook_sapling//eden/fs/service:main
gh_facebook_sapling//eden/fs/service:pretty_printers
gh_facebook_sapling//eden/fs/service:server
gh_facebook_sapling//eden/fs/service:startup_logger
gh_facebook_sapling//eden/fs/service:startup_status_subscriber
gh_facebook_sapling//eden/fs/service:thrift_get_object_impl
gh_facebook_sapling//eden/fs/service:thrift_glob_impl
gh_facebook_sapling//eden/fs/service:thrift_startup_status_subscriber
gh_facebook_sapling//eden/fs/service:thrift_util
gh_facebook_sapling//eden/fs/service:usage_service
~/oss/sapling$

@facebook-github-bot
Copy link
Contributor

@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. (Because this pull request was imported automatically, there will not be any future comments.)

name = "edenfs",
srcs = [
"facebook/main.cpp",
"oss/main.cpp",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This probably needs an internal/external switch.


[external_cell_gh_facebook_buck2_shims_meta]
git_origin = https://github.com/facebook/buck2-shims-meta.git
commit_hash = edb600cfbf0b23dd5e6506912d71ada4185d4c45
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This hash is required (contains several updates to buck2-shims-meta).

@facebook-github-bot
Copy link
Contributor

@ben-- has updated the pull request. You must reimport the pull request before landing.

@ben-- ben-- marked this pull request as ready for review July 1, 2025 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants