Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add necessary third party libs #124

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Commits on May 29, 2024

  1. Update buckconfig

    Summary:
    Update necessary cells in ```.buckconfig``` to BUCK2 build
    Using https://buck2.build/docs/api/build/globals/#read_config to read ```oss_depends_on``` to decide how we want to change the paths in D57915321
    
    Reviewed By: bigfootjon
    
    Differential Revision: D57914226
    namanahuja authored and facebook-github-bot committed May 29, 2024
    Configuration menu
    Copy the full SHA
    3adef2a View commit details
    Browse the repository at this point in the history
  2. Comment out meta only code from Github (facebookincubator#122)

    Summary:
    
    as title
    
    Reviewed By: bigfootjon
    
    Differential Revision: D57914800
    namanahuja authored and facebook-github-bot committed May 29, 2024
    Configuration menu
    Copy the full SHA
    e72c86a View commit details
    Browse the repository at this point in the history
  3. ][build+test] Bad targets for open source build

    Summary: I will work on these targets and see how to resolve them if possible.
    
    Reviewed By: bigfootjon
    
    Differential Revision: D57914985
    namanahuja authored and facebook-github-bot committed May 29, 2024
    Configuration menu
    Copy the full SHA
    365861e View commit details
    Browse the repository at this point in the history
  4. Update deps paths

    Summary:
    X-link: facebook/ocamlrep#81
    
    Update the deps resolution path in BUCK depending on ```oss_depends_on``` in ```.buckconfig```
    
    Reviewed By: bigfootjon
    
    Differential Revision: D57915321
    namanahuja authored and facebook-github-bot committed May 29, 2024
    Configuration menu
    Copy the full SHA
    eddf3dc View commit details
    Browse the repository at this point in the history
  5. Add necessary third party libs

    Summary: These are necessary to buck build fizz
    
    Reviewed By: bigfootjon
    
    Differential Revision: D57915931
    namanahuja authored and facebook-github-bot committed May 29, 2024
    Configuration menu
    Copy the full SHA
    8c662d0 View commit details
    Browse the repository at this point in the history