Add ipprefix cast operators for ipaddr [2/n] #11481
Open
+384
−118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D65641994 |
✅ Deploy Preview for meta-velox canceled.
|
yuandagits
added a commit
to yuandagits/velox
that referenced
this pull request
Nov 8, 2024
Summary: Support casting ipprefix -> ipaddress, and ipaddress -> ipprefix. We just need one new helper function, tryIpPrefixLengthFromIPAddressType, which takes in int128_t, gets the ippaddress, and then we check if the ippaddress is ipv4 or ipv6 mapped. We return 32 for ipv4 and 128 for ipv6 mapped. Differential Revision: D65641994
yuandagits
force-pushed
the
export-D65641994
branch
from
9e09303
to
c52575c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65641994 |
yuandagits
added a commit
to yuandagits/velox
that referenced
this pull request
Nov 8, 2024
Summary: Support casting ipprefix -> ipaddress, and ipaddress -> ipprefix. We just need one new helper function, tryIpPrefixLengthFromIPAddressType, which takes in int128_t, gets the ippaddress, and then we check if the ippaddress is ipv4 or ipv6 mapped. We return 32 for ipv4 and 128 for ipv6 mapped. Differential Revision: D65641994
yuandagits
force-pushed
the
export-D65641994
branch
from
c52575c
to
2396dc2
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65641994 |
mohsaka
suggested changes
Nov 8, 2024
There was a problem hiding this comment.
You can take a look at my updated PRs with addressed comments.
https://github.com/facebookincubator/velox/pull/11309/files
https://github.com/facebookincubator/velox/pull/11378/files
Also here is the functions one if you are doing that too
#11407
Will be going on vacation so feel free to get yours merged!👍
|
|
||
| context.applyToSelectedNoThrow(rows, [&](auto row) { | ||
| auto intIpAddr = ipAddrVector->valueAt(row); | ||
| const auto tryPrefixLength = |
There was a problem hiding this comment.
I don't think this is particularly necessary as the entire range of the 16 byte array are all valid ips.
There was a problem hiding this comment.
Hm make sense, but I still need to get the prefix length. I don't think the cost of the check is expensive
thanks! I wasn't aware of your PRs 😅, I will take a look at your pointers |
yuandagits
added a commit
to yuandagits/velox
that referenced
this pull request
Nov 8, 2024
Summary: Support casting ipprefix -> ipaddress, and ipaddress -> ipprefix. We just need one new helper function, tryIpPrefixLengthFromIPAddressType, which takes in int128_t, gets the ippaddress, and then we check if the ippaddress is ipv4 or ipv6 mapped. We return 32 for ipv4 and 128 for ipv6 mapped. Also applies suggestion from https://github.com/facebookincubator/velox/pull/11309/files Differential Revision: D65641994
yuandagits
force-pushed
the
export-D65641994
branch
from
2396dc2
to
ec7ed79
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65641994 |
yuandagits
added a commit
to yuandagits/velox
that referenced
this pull request
Nov 12, 2024
Summary: Support casting ipprefix -> ipaddress, and ipaddress -> ipprefix. We just need one new helper function, tryIpPrefixLengthFromIPAddressType, which takes in int128_t, gets the ippaddress, and then we check if the ippaddress is ipv4 or ipv6 mapped. We return 32 for ipv4 and 128 for ipv6 mapped. Also applies suggestion from https://github.com/facebookincubator/velox/pull/11309/files Differential Revision: D65641994
yuandagits
added a commit
to yuandagits/velox
that referenced
this pull request
Nov 12, 2024
Summary: Support casting ipprefix -> ipaddress, and ipaddress -> ipprefix. We just need one new helper function, tryIpPrefixLengthFromIPAddressType, which takes in int128_t, gets the ippaddress, and then we check if the ippaddress is ipv4 or ipv6 mapped. We return 32 for ipv4 and 128 for ipv6 mapped. Also applies suggestion from https://github.com/facebookincubator/velox/pull/11309/files Differential Revision: D65641994
yuandagits
added a commit
to yuandagits/velox
that referenced
this pull request
Nov 12, 2024
Summary: Support casting ipprefix -> ipaddress, and ipaddress -> ipprefix. We just need one new helper function, tryIpPrefixLengthFromIPAddressType, which takes in int128_t, gets the ippaddress, and then we check if the ippaddress is ipv4 or ipv6 mapped. We return 32 for ipv4 and 128 for ipv6 mapped. Also applies suggestion from https://github.com/facebookincubator/velox/pull/11309/files Differential Revision: D65641994
yuandagits
added a commit
to yuandagits/velox
that referenced
this pull request
Nov 12, 2024
Summary: Support casting ipprefix -> ipaddress, and ipaddress -> ipprefix. We just need one new helper function, tryIpPrefixLengthFromIPAddressType, which takes in int128_t, gets the ippaddress, and then we check if the ippaddress is ipv4 or ipv6 mapped. We return 32 for ipv4 and 128 for ipv6 mapped. Also applies suggestion from https://github.com/facebookincubator/velox/pull/11309/files Differential Revision: D65641994
yuandagits
added a commit
to yuandagits/velox
that referenced
this pull request
Nov 12, 2024
Summary: Support casting ipprefix -> ipaddress, and ipaddress -> ipprefix. We just need one new helper function, tryIpPrefixLengthFromIPAddressType, which takes in int128_t, gets the ippaddress, and then we check if the ippaddress is ipv4 or ipv6 mapped. We return 32 for ipv4 and 128 for ipv6 mapped. Also applies suggestion from https://github.com/facebookincubator/velox/pull/11309/files Differential Revision: D65641994
yuandagits
added a commit
to yuandagits/velox
that referenced
this pull request
Nov 12, 2024
Summary: Support casting ipprefix -> ipaddress, and ipaddress -> ipprefix. We just need one new helper function, tryIpPrefixLengthFromIPAddressType, which takes in int128_t, gets the ippaddress, and then we check if the ippaddress is ipv4 or ipv6 mapped. We return 32 for ipv4 and 128 for ipv6 mapped. Also applies suggestion from https://github.com/facebookincubator/velox/pull/11309/files Differential Revision: D65641994
yuandagits
force-pushed
the
export-D65641994
branch
from
ec7ed79
to
5b03b71
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65641994 |
yuandagits
added a commit
to yuandagits/velox
that referenced
this pull request
Nov 12, 2024
Summary: Support casting ipprefix -> ipaddress, and ipaddress -> ipprefix. We just need one new helper function, tryIpPrefixLengthFromIPAddressType, which takes in int128_t, gets the ippaddress, and then we check if the ippaddress is ipv4 or ipv6 mapped. We return 32 for ipv4 and 128 for ipv6 mapped. Also applies suggestion from https://github.com/facebookincubator/velox/pull/11309/files Differential Revision: D65641994
yuandagits
force-pushed
the
export-D65641994
branch
from
5b03b71
to
90d17b2
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65641994 |
Summary: Support casting ipprefix -> ipaddress, and ipaddress -> ipprefix. We just need one new helper function, tryIpPrefixLengthFromIPAddressType, which takes in int128_t, gets the ippaddress, and then we check if the ippaddress is ipv4 or ipv6 mapped. We return 32 for ipv4 and 128 for ipv6 mapped. Also applies suggestion from https://github.com/facebookincubator/velox/pull/11309/files Differential Revision: D65641994
yuandagits
force-pushed
the
export-D65641994
branch
from
90d17b2
to
dccca64
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65641994 |
yuandagits
added a commit
to yuandagits/velox
that referenced
this pull request
Nov 12, 2024
Summary: Support casting ipprefix -> ipaddress, and ipaddress -> ipprefix. We just need one new helper function, tryIpPrefixLengthFromIPAddressType, which takes in int128_t, gets the ippaddress, and then we check if the ippaddress is ipv4 or ipv6 mapped. We return 32 for ipv4 and 128 for ipv6 mapped. Also applies suggestion from https://github.com/facebookincubator/velox/pull/11309/files Differential Revision: D65641994
yuandagits
added a commit
to yuandagits/velox
that referenced
this pull request
Nov 12, 2024
Summary: Support casting ipprefix -> ipaddress, and ipaddress -> ipprefix. We just need one new helper function, tryIpPrefixLengthFromIPAddressType, which takes in int128_t, gets the ippaddress, and then we check if the ippaddress is ipv4 or ipv6 mapped. We return 32 for ipv4 and 128 for ipv6 mapped. Also applies suggestion from https://github.com/facebookincubator/velox/pull/11309/files Differential Revision: D65641994
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Support casting ipprefix -> ipaddress, and ipaddress -> ipprefix.
We just need one new helper function, tryIpPrefixLengthFromIPAddressType, which takes in int128_t, gets the ippaddress, and then we check if the ippaddress is ipv4 or ipv6 mapped. We return 32 for ipv4 and 128 for ipv6 mapped.
Differential Revision: D65641994