- Fix FlatVector copy memory issue (#11482) #11483
Open
+84
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: When copy-ing a FlatVector the source memory pool is used. This is a problem when the vector needs to live beyond the lifetime of the source pool. For strings this requires recomputing new StringViews over newly copied string buffers. This is useful in cases where you need to maintain result rows beyond the lifetime of a given presto task / query. Reviewed By: arhimondr Differential Revision: D65306907
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
|
This pull request was exported from Phabricator. Differential Revision: D65306907 |
arhimondr
approved these changes
Nov 8, 2024
| @@ -274,12 +274,13 @@ class FlatVector final : public SimpleVector<T> { | |||
|
|
|||
| VectorPtr copyPreserveEncodings( | |||
| velox::memory::MemoryPool* pool = nullptr) const override { | |||
| auto allocPool = pool ? pool : BaseVector::pool_; | |||
| template <> | ||
| VectorPtr FlatVector<StringView>::copyPreserveEncodings( | ||
| velox::memory::MemoryPool* pool) const { | ||
| auto allocPool = pool ? pool : BaseVector::pool_; |
| auto newValuesBuffer = | ||
| AlignedBuffer::allocate<StringView>(BaseVector::size(), allocPool); | ||
| auto rawCopyValues = newValuesBuffer->asMutable<StringView>(); | ||
| // Copy non Null StringViews to value buffer |
| } | ||
| } | ||
|
|
||
| BufferPtr newStringBuffer = nullptr; |
There was a problem hiding this comment.
std::vector stringBuffers, and emplace_back to it if have
|
Please remove - in the title |
xiaoxmeng
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
When copy-ing a FlatVector the source memory pool is used. This is a problem when the vector needs to live beyond the lifetime of the source pool.
For strings this requires recomputing new StringViews over newly copied string buffers. This is useful in cases where you need to maintain result rows beyond the lifetime of a given presto task / query.
Reviewed By: arhimondr
Differential Revision: D65306907