Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused-variable in velox/common/memory/tests/ArbitrationParticipantTest.cpp #11486

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove unused-variable in velox/common/memory/tests/ArbitrationParticipantTest.cpp #11486

wants to merge 1 commit into from

Commits on Nov 8, 2024

  1. Remove unused-variable in velox/common/memory/tests/ArbitrationPartic… 

    …ipantTest.cpp

Summary:
LLVM-15 has a warning `-Wunused-variable` which we treat as an error because it's so often diagnostic of a code issue. Unused variables can compromise readability or, worse, performance.

This diff either (a) removes an unused variable and, possibly, it's associated code or (b) qualifies the variable with `[[maybe_unused]]`.

#buildsonlynotests - Builds are sufficient

 - If you approve of this diff, please use the "Accept & Ship" button :-)

Differential Revision: D65584155
    @r-barnes @facebook-github-bot
    r-barnes authored and facebook-github-bot committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    fd96f35 View commit details
    Browse the repository at this point in the history