Add comparison support for RowView #11499
Open
+219
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
|
This pull request was exported from Phabricator. Differential Revision: D65700875 |
yuandagits
added a commit
to yuandagits/velox
that referenced
this pull request
Nov 11, 2024
Summary: Support comparison for RowView. This will allow us to compare IPPrefix which has an underlying type of Row<int128_t, int8_t>. When doing between and other comparison operations, RowView's comparisons are not implemented. We can extend RowView's comparison similar to GenericView. I introduce a base class which does the comparisons. The classes which implement the base class can specialize how they want to implement compare. For RowView, I iterate through the underlying tuple 1 by 1 until we find the first match where the underlying RowVector returns a non-zero comparison. Differential Revision: D65700875
yuandagits
force-pushed
the
export-D65700875
branch
from
53bb5a6
to
914b8f9
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65700875 |
yuandagits
added a commit
to yuandagits/velox
that referenced
this pull request
Nov 11, 2024
Summary: Support comparison for RowView. This will allow us to compare IPPrefix which has an underlying type of Row<int128_t, int8_t>. When doing between and other comparison operations, RowView's comparisons are not implemented. We can extend RowView's comparison similar to GenericView. I introduce a base class which does the comparisons. The classes which implement the base class can specialize how they want to implement compare. For RowView, I iterate through the underlying tuple 1 by 1 until we find the first match where the underlying RowVector returns a non-zero comparison. Differential Revision: D65700875
yuandagits
force-pushed
the
export-D65700875
branch
from
914b8f9
to
d7c5383
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65700875 |
yuandagits
added a commit
to yuandagits/velox
that referenced
this pull request
Nov 11, 2024
Summary: Support comparison for RowView. This will allow us to compare IPPrefix which has an underlying type of Row<int128_t, int8_t>. When doing between and other comparison operations, RowView's comparisons are not implemented. We can extend RowView's comparison similar to GenericView. I introduce a base class which does the comparisons. The classes which implement the base class can specialize how they want to implement compare. For RowView, I iterate through the underlying tuple 1 by 1 until we find the first match where the underlying RowVector returns a non-zero comparison. Differential Revision: D65700875
yuandagits
force-pushed
the
export-D65700875
branch
from
d7c5383
to
9632e60
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65700875 |
yuandagits
force-pushed
the
export-D65700875
branch
from
9632e60
to
8f05a0b
Compare
yuandagits
added a commit
to yuandagits/velox
that referenced
this pull request
Nov 13, 2024
Summary: Support comparison for RowView. This will allow us to compare IPPrefix which has an underlying type of Row<int128_t, int8_t>. When doing between and other comparison operations, RowView's comparisons are not implemented. We can extend RowView's comparison similar to GenericView. I introduce a base class which does the comparisons. The classes which implement the base class can specialize how they want to implement compare. For RowView, I iterate through the underlying tuple 1 by 1 until we find the first match where the underlying RowVector returns a non-zero comparison. Differential Revision: D65700875
|
This pull request was exported from Phabricator. Differential Revision: D65700875 |
yuandagits
force-pushed
the
export-D65700875
branch
from
8f05a0b
to
b2448c2
Compare
yuandagits
added a commit
to yuandagits/velox
that referenced
this pull request
Nov 13, 2024
Summary: Support comparison for RowView. This will allow us to compare IPPrefix which has an underlying type of Row<int128_t, int8_t>. When doing between and other comparison operations, RowView's comparisons are not implemented. We can extend RowView's comparison similar to GenericView. I introduce a base class which does the comparisons. The classes which implement the base class can specialize how they want to implement compare. For RowView, I iterate through the underlying tuple 1 by 1 until we find the first match where the underlying RowVector returns a non-zero comparison. Differential Revision: D65700875
|
This pull request was exported from Phabricator. Differential Revision: D65700875 |
yuandagits
added a commit
to yuandagits/velox
that referenced
this pull request
Nov 13, 2024
Summary: Support comparison for RowView. This will allow us to compare IPPrefix which has an underlying type of Row<int128_t, int8_t>. When doing between and other comparison operations, RowView's comparisons are not implemented. We can extend RowView's comparison similar to GenericView. I introduce a base class which does the comparisons. The classes which implement the base class can specialize how they want to implement compare. For RowView, I iterate through the underlying tuple 1 by 1 until we find the first match where the underlying RowVector returns a non-zero comparison. Differential Revision: D65700875
yuandagits
force-pushed
the
export-D65700875
branch
from
b2448c2
to
56b4a33
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65700875 |
Summary: Support comparison for RowView. This will allow us to compare IPPrefix which has an underlying type of Row<int128_t, int8_t>. When doing between and other comparison operations, RowView's comparisons are not implemented. We can extend RowView's comparison similar to GenericView. I introduce a base class which does the comparisons. The classes which implement the base class can specialize how they want to implement compare. For RowView, I iterate through the underlying tuple 1 by 1 until we find the first match where the underlying RowVector returns a non-zero comparison. Differential Revision: D65700875
yuandagits
force-pushed
the
export-D65700875
branch
from
56b4a33
to
c74f6db
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65700875 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Support comparison for RowView. This will allow us to compare IPPrefix which has an underlying type of Row<int128_t, int8_t>.
When doing between and other comparison operations, RowView's comparisons are not implemented. We can extend RowView's comparison similar to GenericView.
I introduce a base class which does the comparisons. The classes which implement the base class can specialize how they want to implement compare.
For RowView, I iterate through the underlying tuple 1 by 1 until we find the first match where the underlying RowVector returns a non-zero comparison.
Differential Revision: D65700875