Buckify breeze #11512

Yuhta · 2024-11-12T15:41:18Z

Differential Revision: D65797319

netlify · 2024-11-12T15:41:37Z

✅ Deploy Preview for meta-velox canceled.

Name	Link
🔨 Latest commit	`55bbfb3`
🔍 Latest deploy log	https://app.netlify.com/sites/meta-velox/deploys/67353b3fd569060008ee6f9d

facebook-github-bot · 2024-11-12T15:41:50Z

This pull request was exported from Phabricator. Differential Revision: D65797319

facebook-github-bot · 2024-11-13T02:17:48Z

This pull request was exported from Phabricator. Differential Revision: D65797319

Summary: Pull Request resolved: facebookincubator#11512 bypass-github-export-checks Reviewed By: oerling Differential Revision: D65797319

facebook-github-bot · 2024-11-13T02:26:21Z

This pull request was exported from Phabricator. Differential Revision: D65797319

Summary: Pull Request resolved: facebookincubator#11512 bypass-github-export-checks Reviewed By: oerling Differential Revision: D65797319

facebook-github-bot · 2024-11-13T02:33:32Z

This pull request was exported from Phabricator. Differential Revision: D65797319

Summary: Pull Request resolved: facebookincubator#11512 bypass-github-export-checks Reviewed By: oerling Differential Revision: D65797319

aditi-pandit · 2024-11-13T05:00:09Z

@Yuhta : Just curious. What is breeze ?

Yuhta · 2024-11-13T16:06:41Z

@aditi-pandit Breeze is a new library developed by Rivos for cross platform SIMT acceleration. We keep it inside Velox so that it can be co-evolved with Velox.

Yuhta · 2024-11-13T16:24:49Z

CC: @dreveman

Summary: Breeze is a new library developed by Rivos for cross platform SIMT acceleration. We keep it inside Velox so that it can be co-evolved with Velox. Pull Request resolved: facebookincubator#11512 bypass-github-export-checks Reviewed By: oerling Differential Revision: D65797319

facebook-github-bot · 2024-11-13T18:25:31Z

This pull request was exported from Phabricator. Differential Revision: D65797319

Summary: Breeze is a new library developed by Rivos for cross platform SIMT acceleration. We keep it inside Velox so that it can be co-evolved with Velox. Pull Request resolved: facebookincubator#11512 bypass-github-export-checks Reviewed By: oerling Differential Revision: D65797319

facebook-github-bot · 2024-11-13T18:43:53Z

This pull request was exported from Phabricator. Differential Revision: D65797319

Summary: Breeze is a new library developed by Rivos for cross platform SIMT acceleration. We keep it inside Velox so that it can be co-evolved with Velox. Pull Request resolved: facebookincubator#11512 bypass-github-export-checks Reviewed By: oerling Differential Revision: D65797319

facebook-github-bot · 2024-11-13T18:49:06Z

This pull request was exported from Phabricator. Differential Revision: D65797319

facebook-github-bot · 2024-11-13T19:32:37Z

This pull request was exported from Phabricator. Differential Revision: D65797319

Summary: Breeze is a new library developed by Rivos for cross platform SIMT acceleration. We keep it inside Velox so that it can be co-evolved with Velox. Pull Request resolved: facebookincubator#11512 bypass-github-export-checks Reviewed By: oerling Differential Revision: D65797319

majetideepak · 2024-11-13T20:40:56Z

velox/experimental/wave/common/tests/CMakeLists.txt

@@ -26,6 +27,7 @@ add_executable(
 add_test(velox_wave_common_test velox_wave_common_test)
 set_tests_properties(velox_wave_common_test PROPERTIES LABELS cuda_driver)

+target_include_directories(velox_wave_common_test PRIVATE ../../../breeze)


Better to use a header-only library for CMake.
https://discourse.cmake.org/t/header-only-library/5476

I will leave this to @dreveman to encapsulate the library in a cmake project

Yep, sounds like a good thing to do as a follow up.

Summary: Breeze is a new library developed by Rivos for cross platform SIMT acceleration. We keep it inside Velox so that it can be co-evolved with Velox. Pull Request resolved: facebookincubator#11512 bypass-github-export-checks Reviewed By: oerling Differential Revision: D65797319

facebook-github-bot · 2024-11-13T22:26:15Z

This pull request was exported from Phabricator. Differential Revision: D65797319

facebook-github-bot · 2024-11-13T22:33:50Z

This pull request was exported from Phabricator. Differential Revision: D65797319

Summary: Breeze is a new library developed by Rivos for cross platform SIMT acceleration. We keep it inside Velox so that it can be co-evolved with Velox. Pull Request resolved: facebookincubator#11512 bypass-github-export-checks Reviewed By: oerling Differential Revision: D65797319

facebook-github-bot · 2024-11-13T23:50:22Z

This pull request was exported from Phabricator. Differential Revision: D65797319

dreveman

lgtm. just some suggestions but they can also be done as follow ups

dreveman · 2024-11-14T16:02:57Z

velox/experimental/breeze/breeze/platforms/openmp.h

@@ -235,7 +235,7 @@ struct OpenMPPlatform {
  inline unsigned lower_rank_lanemask() {
    static_assert(WARP_THREADS <= sizeof(unsigned) * 8,
                  "WARP_THREADS must be less or equal to unsigned bits");
-    return (1 << lane_idx()) - 1;
+    return (1u << lane_idx()) - 1;


can you move this change to a separate commit that has a short commit message explaining the need for it?

dreveman · 2024-11-14T16:03:50Z

velox/experimental/breeze/breeze/utils/types.h

@@ -166,7 +166,7 @@ class BadDeviceAlloc : public std::exception {
                 ",free=" + std::to_string(free) +
                 ",total=" + std::to_string(total) + ")") {}

-  virtual const char *what() const throw() { return message_.c_str(); }
+  virtual const char *what() const noexcept { return message_.c_str(); }


same here. separate commit would be nice for this.

dreveman · 2024-11-14T16:14:41Z

velox/experimental/breeze/test/generated/algorithms/algorithm_test-openmp.h

+// Copyright (c) 2024 by Rivos Inc.
+// Licensed under the Apache License, Version 2.0, see LICENSE for details.
+// SPDX-License-Identifier: Apache-2.0
+


Now that we're checking in this code. Let's make the generator code add a comment here that makes it clear that this file was auto-generated and should not be edited directly. Something like:

/* * This file is auto-generated from test/generate.sh * DO NOT EDIT! */

Sorry only saw this comment after merging, it's a good idea, can you add it to #11537?

Yep, I’ll take care of it

dreveman · 2024-11-14T16:21:48Z

velox/experimental/wave/common/tests/CMakeLists.txt

@@ -26,6 +27,7 @@ add_executable(
 add_test(velox_wave_common_test velox_wave_common_test)
 set_tests_properties(velox_wave_common_test PROPERTIES LABELS cuda_driver)

+target_include_directories(velox_wave_common_test PRIVATE ../../../breeze)


Yep, sounds like a good thing to do as a follow up.

facebook-github-bot · 2024-11-14T16:28:48Z

This pull request has been merged in c069192.

conbench-facebook · 2024-11-14T16:57:27Z

Conbench analyzed the 1 benchmark run on commit c069192e.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

Yuhta requested review from assignUser and majetideepak as code owners November 12, 2024 15:41

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 12, 2024

facebook-github-bot added the fb-exported label Nov 12, 2024

Yuhta force-pushed the export-D65797319 branch from f881f9b to c9b3c99 Compare November 13, 2024 02:17

Yuhta added a commit to Yuhta/velox that referenced this pull request Nov 13, 2024

Buckify breeze (facebookincubator#11512)

c9b3c99

Summary: Pull Request resolved: facebookincubator#11512 bypass-github-export-checks Reviewed By: oerling Differential Revision: D65797319

Yuhta added a commit to Yuhta/velox that referenced this pull request Nov 13, 2024

Buckify breeze (facebookincubator#11512)

88c5a78

Summary: Pull Request resolved: facebookincubator#11512 bypass-github-export-checks Reviewed By: oerling Differential Revision: D65797319

Yuhta force-pushed the export-D65797319 branch from c9b3c99 to 88c5a78 Compare November 13, 2024 02:26

Yuhta added a commit to Yuhta/velox that referenced this pull request Nov 13, 2024

Buckify breeze (facebookincubator#11512)

3b1e499

Summary: Pull Request resolved: facebookincubator#11512 bypass-github-export-checks Reviewed By: oerling Differential Revision: D65797319

Yuhta force-pushed the export-D65797319 branch from 88c5a78 to 3b1e499 Compare November 13, 2024 02:33

Yuhta force-pushed the export-D65797319 branch from 3b1e499 to b98dcf0 Compare November 13, 2024 18:25

Yuhta force-pushed the export-D65797319 branch from b98dcf0 to 9cdb7ec Compare November 13, 2024 18:43

Yuhta force-pushed the export-D65797319 branch from 9cdb7ec to 945516c Compare November 13, 2024 18:49

Yuhta force-pushed the export-D65797319 branch from 945516c to 34a9512 Compare November 13, 2024 19:32

majetideepak reviewed Nov 13, 2024

View reviewed changes

Yuhta force-pushed the export-D65797319 branch from 34a9512 to 191110b Compare November 13, 2024 22:26

Yuhta force-pushed the export-D65797319 branch from 191110b to 4db266a Compare November 13, 2024 22:33

Yuhta force-pushed the export-D65797319 branch from 4db266a to 55bbfb3 Compare November 13, 2024 23:50

dreveman approved these changes Nov 14, 2024

View reviewed changes

facebook-github-bot closed this in c069192 Nov 14, 2024

facebook-github-bot added the Merged label Nov 14, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Buckify breeze #11512

Buckify breeze #11512

Yuhta commented Nov 12, 2024

netlify bot commented Nov 12, 2024 •

edited

Loading

facebook-github-bot commented Nov 12, 2024

facebook-github-bot commented Nov 13, 2024

facebook-github-bot commented Nov 13, 2024

facebook-github-bot commented Nov 13, 2024

aditi-pandit commented Nov 13, 2024

Yuhta commented Nov 13, 2024

Yuhta commented Nov 13, 2024

facebook-github-bot commented Nov 13, 2024

facebook-github-bot commented Nov 13, 2024

facebook-github-bot commented Nov 13, 2024

facebook-github-bot commented Nov 13, 2024

majetideepak Nov 13, 2024

Yuhta Nov 13, 2024

dreveman Nov 14, 2024

facebook-github-bot commented Nov 13, 2024

facebook-github-bot commented Nov 13, 2024

facebook-github-bot commented Nov 13, 2024

dreveman left a comment

dreveman Nov 14, 2024

dreveman Nov 14, 2024

dreveman Nov 14, 2024

Yuhta Nov 14, 2024

dreveman Nov 14, 2024

dreveman Nov 14, 2024

facebook-github-bot commented Nov 14, 2024

conbench-facebook bot commented Nov 14, 2024

Buckify breeze #11512

Buckify breeze #11512

Conversation

Yuhta commented Nov 12, 2024

netlify bot commented Nov 12, 2024 • edited Loading

✅ Deploy Preview for meta-velox canceled.

facebook-github-bot commented Nov 12, 2024

facebook-github-bot commented Nov 13, 2024

facebook-github-bot commented Nov 13, 2024

facebook-github-bot commented Nov 13, 2024

aditi-pandit commented Nov 13, 2024

Yuhta commented Nov 13, 2024

Yuhta commented Nov 13, 2024

facebook-github-bot commented Nov 13, 2024

facebook-github-bot commented Nov 13, 2024

facebook-github-bot commented Nov 13, 2024

facebook-github-bot commented Nov 13, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

facebook-github-bot commented Nov 13, 2024

facebook-github-bot commented Nov 13, 2024

facebook-github-bot commented Nov 13, 2024

dreveman left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

facebook-github-bot commented Nov 14, 2024

conbench-facebook bot commented Nov 14, 2024

netlify bot commented Nov 12, 2024 •

edited

Loading