Add ip_subnet_max/min [4/n] #11515
Open
Add ip_subnet_max/min [4/n] #11515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
|
This pull request was exported from Phabricator. Differential Revision: D65833249 |
yuandagits
added a commit
to yuandagits/velox
that referenced
this pull request
Nov 12, 2024
Summary: Add ip_subnet and ip_subnetmax. Split from facebookincubator#11407 Differential Revision: D65833249
yuandagits
force-pushed
the
export-D65833249
branch
from
5198043
to
fb57c78
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65833249 |
yuandagits
added a commit
to yuandagits/velox
that referenced
this pull request
Nov 12, 2024
Summary: Add ip_subnet and ip_subnetmax. Split from facebookincubator#11407 Differential Revision: D65833249
yuandagits
force-pushed
the
export-D65833249
branch
from
fb57c78
to
72f28a7
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65833249 |
yuandagits
added a commit
to yuandagits/velox
that referenced
this pull request
Nov 12, 2024
Summary: Add ip_subnet and ip_subnetmax. Split from facebookincubator#11407 Differential Revision: D65833249
yuandagits
force-pushed
the
export-D65833249
branch
from
72f28a7
to
51361cd
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65833249 |
Summary: Support casting ipprefix -> ipaddress, and ipaddress -> ipprefix. We just need one new helper function, tryIpPrefixLengthFromIPAddressType, which takes in int128_t, gets the ippaddress, and then we check if the ippaddress is ipv4 or ipv6 mapped. We return 32 for ipv4 and 128 for ipv6 mapped. Also applies suggestion from https://github.com/facebookincubator/velox/pull/11309/files Differential Revision: D65641994
Summary: Add ip_prefix function which takes in varchar or ipaddress along with a prefixBits. Use folly lib to convert the varchar or ipaddress type to folly::IPAddressV6, and then apply the mask. We return a tuple<int128_t, int8_t> which corresponds to the ipaddress and prefix for IPAddressPrefix type. Split from facebookincubator#11407 Differential Revision: D65802211
Summary: Add ip_subnet and ip_subnetmax. Split from facebookincubator#11407 Differential Revision: D65833249
yuandagits
force-pushed
the
export-D65833249
branch
from
51361cd
to
8216001
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65833249 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Add ip_subnet and ip_subnetmax.
Split from #11407
Differential Revision: D65833249