Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(ci): Add conventional commit title check #11520

Closed
wants to merge 6 commits into from
Closed

build(ci): Add conventional commit title check #11520

wants to merge 6 commits into from
+25 −0

Conversation

assignUser
Copy link
Collaborator

@assignUser assignUser commented Nov 13, 2024 •
edited
Loading

Check the PR title against cc pattern added in #11356. Fails with a pointer to CONTRIBUTING.md.
We are running the title change on every commit as it takes under 5 seconds to run and this way we avoid weird states with skipped checks overriding failed results when the title was triggered outside of a commit.

We could add a comment to the PR but that would require a workflow with elevated permissions using pull_request_target which should be avoided if possible. So I think the marginally lower ux is justified, we still get a marker/reminder for reviewers through this job.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 13, 2024
@netlify Netlify
Copy link

netlify bot commented Nov 13, 2024 •
edited
Loading

✅ Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit 3167981
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/673477f0a8f44f0008296f55

@assignUser assignUser changed the title misc(ci): add conventional commit title check add conventional commit title check Nov 13, 2024
@assignUser assignUser changed the title add conventional commit title check misc(ci): add conventional commit title check Nov 13, 2024
@assignUser assignUser changed the title misc(ci): add conventional commit title check add conventional commit title check Nov 13, 2024
@assignUser assignUser changed the title add conventional commit title check misc(ci): add conventional commit title check Nov 13, 2024
@pedroerp
Copy link
Contributor

nit: aren't we using the "build: " prefix for build and CI related changes?

@assignUser
Copy link
Collaborator Author

Feel free to edit the PR title to test the check.

@assignUser assignUser changed the title misc(ci): add conventional commit title check build(ci): add conventional commit title check Nov 13, 2024
@assignUser assignUser changed the title build(ci): add conventional commit title check build(ci): Add conventional commit title check Nov 13, 2024
@assignUser assignUser changed the title build(ci): Add conventional commit title check build(ci): Add conventional commit title check. Nov 13, 2024
@assignUser assignUser changed the title build(ci): Add conventional commit title check. build(ci)!: Add conventional commit title check Nov 13, 2024
@assignUser assignUser changed the title build(ci)!: Add conventional commit title check build(ci): Add conventional commit title check Nov 13, 2024
@pedroerp pedroerp changed the title build(ci): Add conventional commit title check build(ci): add conventional commit title check Nov 13, 2024
@pedroerp pedroerp changed the title build(ci): add conventional commit title check build(ci): Add conventional commit title check Nov 13, 2024
pedroerp
pedroerp approved these changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@pedroerp pedroerp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this. Very cool!

@pedroerp pedroerp added ready-to-merge PR that have been reviewed and are ready for merging. PRs with this tag notify the Velox Meta oncall build and removed ready-to-merge PR that have been reviewed and are ready for merging. PRs with this tag notify the Velox Meta oncall build labels Nov 13, 2024
majetideepak
majetideepak approved these changes Nov 14, 2024
View reviewed changes
Copy link
Collaborator

@majetideepak majetideepak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@facebook-github-bot
Copy link
Contributor

@Yuhta has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@Yuhta merged this pull request in 88e3e61.

@conbench-facebook conbench-facebook
Copy link

Conbench analyzed the 1 benchmark run on commit 88e3e611.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedroerp pedroerp pedroerp approved these changes

@majetideepak majetideepak majetideepak approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged ready-to-merge PR that have been reviewed and are ready for merging. PRs with this tag notify the Velox Meta oncall
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@assignUser @pedroerp @facebook-github-bot @majetideepak