Add Int64 Timestamp support in Parquet reader #11530
Draft
+70
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
Yuhta
reviewed
Nov 13, 2024
velox/dwio/common/IntDecoder.h
Outdated
| @@ -169,6 +166,7 @@ class IntDecoder { | |||
| void skipVarints(uint64_t items); | |||
| int128_t readVsHugeInt(); | |||
| uint128_t readVuHugeInt(); | |||
| int128_t readTimestamp(); | |||
There was a problem hiding this comment.
IntDecoder should have no knowledge about timestamp. Parse the int64_t inside column reader.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.