Fix PlanNodeStats overflow #11532
Draft
Fix PlanNodeStats overflow #11532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
yingsu00
force-pushed
the
PlanNodeStatsOverflow
branch
from
ac77412
to
b8c47cb
Compare
PlanNodeStats uses vector_size_t for the number of rows counters, but it's actually int32_t. This caused overflow for some cases, e.g. "Exchange: Output: -1734967296 rows (37.14GB, 3171 batches)". This commit fixes it by changing vector_size_t to uint64_t, which is already used for the number of bytes counters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PlanNodeStats uses vector_size_t for the number of rows counters, but
it's actually int32_t. This caused overflow for some cases, e.g.
"Exchange: Output: -1734967296 rows (37.14GB, 3171 batches)". This
commit fixes it by changing vector_size_t to uint64_t, which is already
used for the number of bytes counters.