Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up prefix sort function defaultPrefixSortConfig #11533

Closed
wants to merge 1 commit into from
Closed

Clean up prefix sort function defaultPrefixSortConfig #11533

wants to merge 1 commit into from
+9 −41

Conversation

jinchengchenghh
Copy link
Contributor

No description provided.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 14, 2024
@jinchengchenghh jinchengchenghh changed the title Clean up prefix sort code defaultPrefixSortConfig Clean up prefix sort function defaultPrefixSortConfig Nov 14, 2024
@netlify Netlify
Copy link

netlify bot commented Nov 14, 2024 •
edited
Loading

✅ Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit a36fbd9
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/67356dd982278a00080b01f7

@jinchengchenghh jinchengchenghh force-pushed the prefixclean branch 2 times, most recently from 0264222 to a36fbd9 Compare November 14, 2024 03:26
@Yuhta Yuhta requested a review from xiaoxmeng November 14, 2024 15:42
xiaoxmeng
xiaoxmeng approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@xiaoxmeng xiaoxmeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jinchengchenghh thanks for the cleanup!

@facebook-github-bot
Copy link
Contributor

@xiaoxmeng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@xiaoxmeng merged this pull request in 9494cbc.

@conbench-facebook conbench-facebook
Copy link

Conbench analyzed the 1 benchmark run on commit 9494cbca.

There were 2 benchmark results indicating a performance regression:

The full Conbench report has more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiaoxmeng xiaoxmeng xiaoxmeng approved these changes

@majetideepak majetideepak Awaiting requested review from majetideepak majetideepak is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jinchengchenghh @facebook-github-bot @xiaoxmeng