Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix Inconsistent task execution mode error in presto agg benchmark #12400

Closed
wants to merge 2 commits into from
Closed

fix: Fix Inconsistent task execution mode error in presto agg benchmark #12400

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a8a06f8
fix: Fix Inconsistent task execution mode error in presto agg benchmark
zhli1142015 Feb 20, 2025
fc8d508
minor change
zhli1142015 Feb 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion velox/functions/prestosql/aggregates/benchmarks/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ target_link_libraries(
Folly::follybenchmark
gflags::gflags)

add_executable(velox_aggregates_reduce_agg_bm SimpleAggregates.cpp)
add_executable(velox_aggregates_reduce_agg_bm ReduceAgg.cpp)

target_link_libraries(
velox_aggregates_reduce_agg_bm
Expand Down
2 changes: 1 addition & 1 deletion velox/functions/prestosql/aggregates/benchmarks/ReduceAgg.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ class ReduceAggBenchmark : public HiveConnectorTestBase {
std::move(plan),
0,
core::QueryCtx::create(executor_.get()),
exec::Task::ExecutionMode::kParallel);
exec::Task::ExecutionMode::kSerial);

task->addSplit(
"0", exec::Split(makeHiveConnectorSplit(filePath_->getPath())));
Expand Down
3 changes: 1 addition & 2 deletions velox/functions/prestosql/aggregates/benchmarks/SimpleAggregates.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ namespace {
class SimpleAggregatesBenchmark : public HiveConnectorTestBase {
public:
SimpleAggregatesBenchmark() {
OperatorTestBase::SetUpTestCase();
HiveConnectorTestBase::SetUp();

inputType_ = ROW({
Expand Down Expand Up @@ -166,7 +165,7 @@ class SimpleAggregatesBenchmark : public HiveConnectorTestBase {
std::move(plan),
0,
core::QueryCtx::create(executor_.get()),
exec::Task::ExecutionMode::kParallel);
exec::Task::ExecutionMode::kSerial);
}

private:
Expand Down
2 changes: 1 addition & 1 deletion velox/functions/prestosql/aggregates/benchmarks/TwoStringKeys.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ class TwoStringKeysBenchmark : public HiveConnectorTestBase {
std::move(plan),
0,
core::QueryCtx::create(executor_.get()),
exec::Task::ExecutionMode::kParallel);
exec::Task::ExecutionMode::kSerial);

task->addSplit(
"0", exec::Split(makeHiveConnectorSplit((filePath_->getPath()))));
Expand Down
Loading