fix: Fix incorrect result from casting double to decimal #12600
+24
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When converting 0.03456789 to DECIMAL(38, 33), the result generated by Velox is
inconsistent with Spark and Presto. This discrepancy is caused by precision
errors due to long double multiplication. I propose fixing this issue by first
converting the result to the target type(int64_t / int128_t) and then applying rescaling.
Velox
Spark
Presto