Skip to content

Conversation

@inigohidalgo
Copy link

@inigohidalgo inigohidalgo commented Jul 26, 2022

Kats

Thank you for contributing! Please take a moment to review our contributing guidelines
to make the process easy and effective for everyone involved.

  • Fork the repo and create your branch from main.
  • If you've added code that should be tested, add tests.
  • If you've changed APIs, update the documentation.
  • Ensure the test suite passes.
  • Make sure your code lints.
  • If you haven't already, complete the Contributor License Agreement ("CLA").

PR Description

I am opening this PR to upgrade prophet to 1.1 which removes the pystan dependency, which is no longer maintained: #249

This would make the process of installing Kats on Windows machines 1000x more fluid, as it no longer requires users to build the prophet package themselves, and removes the necessity for installing additional C++ compilers through conda.

Ver: Kats v1.02

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 26, 2022
@inigohidalgo inigohidalgo changed the title feat: update prophet requirement to 1.1 Use prophet (1.1) instead of fbprophet (0.7) Jul 26, 2022
@inigohidalgo inigohidalgo marked this pull request as ready for review July 26, 2022 08:24
@inigohidalgo
Copy link
Author

Hi @iamxiaodong , I saw in #134 that you were not yet ready to merge the updated prophet dependency. Prophet has now released version 1.1 which includes a major QoL improvement, particularly for Windows users as we no longer need to install pystan, which is complicated to install without using conda.

I am opening a new PR as the last one targets prophet 1.0 instead of 1.1 which is the version with this improvement, and merge conflicts have arisen since it was written.

@octavd
Copy link

octavd commented Dec 16, 2022

Hello @inigohidalgo , any news about this PR? will there be a new release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants