Add optional permissions to step-config writing - #315
Open
teonbrooks wants to merge 1 commit into
Open
Conversation
Thread an optional `permissions` argument through `write_configs` and `ConfigDump.check_and_write` to chmod the uid/full-uid/config yamls after writing (`Path.write_text` is otherwise capped by the umask). Backend passes 0o777 so the config yamls match the permissions applied to the cache data files. Adds unit tests.
meta-cla
Bot
added
the
CLA Signed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
YAML files are currently written with a different permission set than the other files. This seeks to unify it.
Thread an optional
permissionsargument throughwrite_configsandConfigDump.check_and_writeto chmod the uid/full-uid/config yamls after writing (Path.write_textis otherwise capped by the umask). Backend passes 0o777 so the config yamls match the permissions applied to the cache data files.Adds unit tests.