Skip to content
This repository was archived by the owner on Nov 1, 2024. It is now read-only.

Conversation

@urielsinger
Copy link
Contributor

@urielsinger urielsinger commented Mar 23, 2023

Small bugs fix:

  • end of epoch logging
  • adding is_ema into stitch_fsdp_ckpt.py
  • adding **kwargs in base_optimizer for clip_grad_norm
  • fix param name in reshard_fsdp
  • pin matplotlib version

@zycalice
Copy link
Contributor

could you fix lint and test? thanks!

@suchenzang
Copy link
Contributor

@zycalice ah - this is on my plate! #679 has some state here too (haven't had time to wrap up yet)

Copy link
Contributor

@suchenzang suchenzang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will fix lint

@urielsinger urielsinger merged commit bc29113 into main Mar 27, 2023
@urielsinger urielsinger deleted the mg_small_bugs branch March 27, 2023 07:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants