Improve convert_model to handle skeleton conversion #829
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
Contributor
facebook-github-bot
temporarily deployed
to
pypi-gpu
GitHub Actions
Inactive
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 15, 2025
Summary: This is to handle the case where we want to apply anim curves in an fbx to a skinned model. Previously, we directly copy over joint parameters, assuming the anim curves are on an identical skeleton as the skinned model. However, even when two skeletons "look" the same, they could still have different joint orders or rest pose / bind pose. A direct copy will fail in these cases. This diff handles such cases more robustly, by mapping global joint transforms between them based on joint names, then convert the transforms back to joint parameters based on the target skeleton's bind pose. We could still be in trouble if InverseParameterTransform is lossy, but that's a different story. `convert_model` is due for refactoring... Differential Revision: D86828693
facebook-github-bot
force-pushed
the
export-D86828693
branch
from
23226bd to
6ab56e2
Compare
Summary: This change adds a parameterized constructor to the FileSaveOptions Python binding, enabling users to initialize all member variables directly when creating the object instead of having to set them one by one after construction. This improves the API ergonomics by allowing cleaner initialization patterns: ```python options = FileSaveOptions(mesh=False, locators=True, blend_shapes=False) ``` Reviewed By: cstollmeta, jeongseok-meta Differential Revision: D86904749
Summary: Replace custom saveMotion with the unified saveCharacter() in character_io, so now marker tracking can save fbx file with marker data. Note that this change removes the behavior of saving the identity vector as joint parameters separately from the motion. The motion matrix now has the identity information in every frame as well. This is what most users do anyways. Reviewed By: jeongseok-meta, cstollmeta Differential Revision: D86040409
Summary: This diff refactors the FBX save functions to use the `FileSaveOptions` struct instead of individual parameters, following the pattern established in D86039901 for GLTF save functions. Differential Revision: D86883821
Summary: This is to handle the case where we want to apply anim curves in an fbx to a skinned model. Previously, we directly copy over joint parameters, assuming the anim curves are on an identical skeleton as the skinned model. However, even when two skeletons "look" the same, they could still have different joint orders or rest pose / bind pose. A direct copy will fail in these cases. This diff handles such cases more robustly, by mapping global joint transforms between them based on joint names, then convert the transforms back to joint parameters based on the target skeleton's bind pose. We could still be in trouble if InverseParameterTransform is lossy, but that's a different story. `convert_model` is due for refactoring... Differential Revision: D86828693
facebook-github-bot
force-pushed
the
export-D86828693
branch
from
6ab56e2 to
9dafa1a
Compare
facebook-github-bot
temporarily deployed
to
pypi-gpu
GitHub Actions
Inactive
facebook-github-bot
temporarily deployed
to
pypi-gpu
GitHub Actions
Inactive
facebook-github-bot
temporarily deployed
to
pypi-cpu
GitHub Actions
Inactive
facebook-github-bot
temporarily deployed
to
pypi-cpu
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This is to handle the case where we want to apply anim curves in an fbx to a skinned model.
Previously, we directly copy over joint parameters, assuming the anim curves are on an identical skeleton as the skinned model. However, even when two skeletons "look" the same, they could still have different joint orders or rest pose / bind pose. A direct copy will fail in these cases.
This diff handles such cases more robustly, by mapping global joint transforms between them based on joint names, then convert the transforms back to joint parameters based on the target skeleton's bind pose.
We could still be in trouble if InverseParameterTransform is lossy, but that's a different story.
convert_modelis due for refactoring...Differential Revision: D86828693