Improve the type hints of _get_params_or_grads()
#170
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D74560386 |
tsunghsienlee
added a commit
to tsunghsienlee/optimizers
that referenced
this pull request
May 19, 2025
tsunghsienlee
force-pushed
the
export-D74560386
branch
from
380bf8b to
3b3dfc9
Compare
) Summary: Pull Request resolved: facebookresearch#170 Figure out how to type hint when there is a default value of `get_grad=False` in `_get_params_or_grads()`. Reviewed By: gajjanag Differential Revision: D74560386
|
This pull request was exported from Phabricator. Differential Revision: D74560386 |
tsunghsienlee
force-pushed
the
export-D74560386
branch
from
3b3dfc9 to
614396a
Compare
|
This pull request has been merged in 77c22d7. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Figure out how to type hint when there is a default value of
get_grad=Falsein_get_params_or_grads().Differential Revision: D74560386