Move per-module tests under each module (#1500)#1500
Open
moto-meta wants to merge 1 commit into
Open
Conversation
meta-cla
Bot
added
the
CLA Signed
Contributor
|
@moto-meta has exported this pull request. If you are a Meta employee, you can view the originating Diff in D107140706. |
moto-meta
pushed a commit
that referenced
this pull request
Jun 1, 2026
Summary: Pull Request resolved: #1500 Reorganize SPDL tests so each module owns its own tests. Tests previously lived under `fbcode/spdl/tests/<module>/` and depended on a shared root for fixtures and Buck macros. After this change, each module's tests live in `<module>/tests/`, which makes `buck test fbcode//spdl/<module>/...` run every test for that module without enumerating sibling test paths. New layout: - `spdl/io/tests/` (was `spdl/tests/io/`) — also hosts the shared `fixture.py` + `fb/__init__.py` (FFmpeg helpers), since only `io` and `cuda` tests use them and `cuda` tests already depend only on `spdl.io`. - `spdl/cuda/tests/` (was `spdl/tests/cuda/`) — `PACKAGE` moved with it; depends on `//spdl/io/tests:fixture` and imports `from spdl.io.tests.fixture`. - `spdl/pipeline/tests/` (was `spdl/tests/pipeline/`, including `fb/`). - `spdl/dataloader/tests/` (was `spdl/tests/dataloader/`). - `spdl/autoresearch/tests/` (was `spdl/tests/autoresearch/`, including `fb/`). - `spdl/def.bzl` — new file holding the `spdl_tests_with_ffmpeg_variants` and `spdl_tests_with_python_variants` macros that were previously in `spdl/tests/def.bzl`. - `fbcode/spdl/tests/` deleted entirely. Other updates: - `from ..fixture` (relative) is now `from .fixture` for `io` tests and `from spdl.io.tests.fixture` (absolute) for `cuda` tests. - `spdl.io.tests/fb/__init__.py` resolves the FFmpeg resource via `importlib.resources.path("spdl.io.tests", "ffmpeg")`. - Visibility lists in module BUCKs (`spdl/io/...`, `spdl/io/lib/...`, `spdl/io/utils/...`, `spdl/pipeline/...`, `spdl/pipeline/_iter_utils/...`, `spdl/pipeline/fb/...`, `spdl/pipeline/fb/lib/...`, `spdl/autoresearch/...`, `spdl/autoresearch/_app/...`, `spdl/autoresearch/_common/fb/...`, `spdl/autoresearch/core/...`, `spdl/autoresearch/pipeline_optimization/...`) updated to point to the new per-module test paths. - `fbcode/spdl/PACKAGE` comments updated to reference the new `tests/` paths. - `fbcode/spdl/.llms/skills/code-authoring/SKILL.md` updated to describe the new layout convention. - GitHub workflows (`_build_linux.yml`, `_build_linux_cuda.yml`, `_build_macos.yml`, `_build_windows.yml`) updated so each pytest invocation lists the new per-module paths under the OSS `src/spdl/` prefix; `docs.yml` `paths-ignore` updated to `src/spdl/**/tests/**`. - Hydra `_target_` string in `pipeline_hydra_test.py` updated from `spdl.tests.pipeline.fb...` to `spdl.pipeline.tests.fb...`. Differential Revision: D107140706
meta-codesync
Bot
changed the title
moto-meta
force-pushed
the
export-D107140706
branch
from
05fd7fa to
e6b9483
Compare
moto-meta
pushed a commit
that referenced
this pull request
Jun 1, 2026
Summary: Pull Request resolved: #1500 Reorganize SPDL tests so each module owns its own tests. Tests previously lived under `fbcode/spdl/tests/<module>/` and depended on a shared root for fixtures and Buck macros. After this change, each module's tests live in `<module>/tests/`, which makes `buck test fbcode//spdl/<module>/...` run every test for that module without enumerating sibling test paths. New layout: - `spdl/io/tests/` (was `spdl/tests/io/`) — also hosts the shared `fixture.py` + `fb/__init__.py` (FFmpeg helpers), since only `io` and `cuda` tests use them and `cuda` tests already depend only on `spdl.io`. - `spdl/cuda/tests/` (was `spdl/tests/cuda/`) — `PACKAGE` moved with it; depends on `//spdl/io/tests:fixture` and imports `from spdl.io.tests.fixture`. - `spdl/pipeline/tests/` (was `spdl/tests/pipeline/`, including `fb/`). - `spdl/dataloader/tests/` (was `spdl/tests/dataloader/`). - `spdl/autoresearch/tests/` (was `spdl/tests/autoresearch/`, including `fb/`). - `spdl/def.bzl` — new file holding the `spdl_tests_with_ffmpeg_variants` and `spdl_tests_with_python_variants` macros that were previously in `spdl/tests/def.bzl`. - `fbcode/spdl/tests/` deleted entirely. Other updates: - `from ..fixture` (relative) is now `from .fixture` for `io` tests and `from spdl.io.tests.fixture` (absolute) for `cuda` tests. - `spdl.io.tests/fb/__init__.py` resolves the FFmpeg resource via `importlib.resources.path("spdl.io.tests", "ffmpeg")`. - Visibility lists in module BUCKs (`spdl/io/...`, `spdl/io/lib/...`, `spdl/io/utils/...`, `spdl/pipeline/...`, `spdl/pipeline/_iter_utils/...`, `spdl/pipeline/fb/...`, `spdl/pipeline/fb/lib/...`, `spdl/autoresearch/...`, `spdl/autoresearch/_app/...`, `spdl/autoresearch/_common/fb/...`, `spdl/autoresearch/core/...`, `spdl/autoresearch/pipeline_optimization/...`) updated to point to the new per-module test paths. - `fbcode/spdl/PACKAGE` comments updated to reference the new `tests/` paths. - `fbcode/spdl/.llms/skills/code-authoring/SKILL.md` updated to describe the new layout convention. - GitHub workflows (`_build_linux.yml`, `_build_linux_cuda.yml`, `_build_macos.yml`, `_build_windows.yml`) updated so each pytest invocation lists the new per-module paths under the OSS `src/spdl/` prefix; `docs.yml` `paths-ignore` updated to `src/spdl/**/tests/**`. - Hydra `_target_` string in `pipeline_hydra_test.py` updated from `spdl.tests.pipeline.fb...` to `spdl.pipeline.tests.fb...`. Differential Revision: D107140706
moto-meta
force-pushed
the
export-D107140706
branch
from
e6b9483 to
7c71d44
Compare
moto-meta
pushed a commit
that referenced
this pull request
Jun 2, 2026
Summary: Pull Request resolved: #1500 Reorganize SPDL tests so each module owns its own tests. Tests previously lived under `fbcode/spdl/tests/<module>/` and depended on a shared root for fixtures and Buck macros. After this change, each module's tests live in `<module>/tests/`, which makes `buck test fbcode//spdl/<module>/...` run every test for that module without enumerating sibling test paths. New layout: - `spdl/io/tests/` (was `spdl/tests/io/`) — also hosts the shared `fixture.py` + `fb/__init__.py` (FFmpeg helpers), since only `io` and `cuda` tests use them and `cuda` tests already depend only on `spdl.io`. - `spdl/cuda/tests/` (was `spdl/tests/cuda/`) — `PACKAGE` moved with it; depends on `//spdl/io/tests:fixture` and imports `from spdl.io.tests.fixture`. - `spdl/pipeline/tests/` (was `spdl/tests/pipeline/`, including `fb/`). - `spdl/dataloader/tests/` (was `spdl/tests/dataloader/`). - `spdl/autoresearch/tests/` (was `spdl/tests/autoresearch/`, including `fb/`). - `spdl/def.bzl` — new file holding the `spdl_tests_with_ffmpeg_variants` and `spdl_tests_with_python_variants` macros that were previously in `spdl/tests/def.bzl`. - `fbcode/spdl/tests/` deleted entirely. Other updates: - `from ..fixture` (relative) is now `from .fixture` for `io` tests and `from spdl.io.tests.fixture` (absolute) for `cuda` tests. - `spdl.io.tests/fb/__init__.py` resolves the FFmpeg resource via `importlib.resources.path("spdl.io.tests", "ffmpeg")`. - Visibility lists in module BUCKs (`spdl/io/...`, `spdl/io/lib/...`, `spdl/io/utils/...`, `spdl/pipeline/...`, `spdl/pipeline/_iter_utils/...`, `spdl/pipeline/fb/...`, `spdl/pipeline/fb/lib/...`, `spdl/autoresearch/...`, `spdl/autoresearch/_app/...`, `spdl/autoresearch/_common/fb/...`, `spdl/autoresearch/core/...`, `spdl/autoresearch/pipeline_optimization/...`) updated to point to the new per-module test paths. - `fbcode/spdl/PACKAGE` comments updated to reference the new `tests/` paths. - `fbcode/spdl/.llms/skills/code-authoring/SKILL.md` updated to describe the new layout convention. - GitHub workflows (`_build_linux.yml`, `_build_linux_cuda.yml`, `_build_macos.yml`, `_build_windows.yml`) updated so each pytest invocation lists the new per-module paths under the OSS `src/spdl/` prefix; `docs.yml` `paths-ignore` updated to `src/spdl/**/tests/**`. - Hydra `_target_` string in `pipeline_hydra_test.py` updated from `spdl.tests.pipeline.fb...` to `spdl.pipeline.tests.fb...`. Differential Revision: D107140706
moto-meta
force-pushed
the
export-D107140706
branch
from
7c71d44 to
4a2236d
Compare
moto-meta
pushed a commit
that referenced
this pull request
Jun 2, 2026
Summary: Pull Request resolved: #1500 Reorganize SPDL tests so each module owns its own tests. Tests previously lived under `fbcode/spdl/tests/<module>/` and depended on a shared root for fixtures and Buck macros. After this change, each module's tests live in `<module>/tests/`, which makes `buck test fbcode//spdl/<module>/...` run every test for that module without enumerating sibling test paths. New layout: - `spdl/io/tests/` (was `spdl/tests/io/`) — also hosts the shared `fixture.py` + `fb/__init__.py` (FFmpeg helpers), since only `io` and `cuda` tests use them and `cuda` tests already depend only on `spdl.io`. - `spdl/cuda/tests/` (was `spdl/tests/cuda/`) — `PACKAGE` moved with it; depends on `//spdl/io/tests:fixture` and imports `from spdl.io.tests.fixture`. - `spdl/pipeline/tests/` (was `spdl/tests/pipeline/`, including `fb/`). - `spdl/dataloader/tests/` (was `spdl/tests/dataloader/`). - `spdl/autoresearch/tests/` (was `spdl/tests/autoresearch/`, including `fb/`). - `spdl/def.bzl` — new file holding the `spdl_tests_with_ffmpeg_variants` and `spdl_tests_with_python_variants` macros that were previously in `spdl/tests/def.bzl`. - `fbcode/spdl/tests/` deleted entirely. Other updates: - `from ..fixture` (relative) is now `from .fixture` for `io` tests and `from spdl.io.tests.fixture` (absolute) for `cuda` tests. - `spdl.io.tests/fb/__init__.py` resolves the FFmpeg resource via `importlib.resources.path("spdl.io.tests", "ffmpeg")`. - Visibility lists in module BUCKs (`spdl/io/...`, `spdl/io/lib/...`, `spdl/io/utils/...`, `spdl/pipeline/...`, `spdl/pipeline/_iter_utils/...`, `spdl/pipeline/fb/...`, `spdl/pipeline/fb/lib/...`, `spdl/autoresearch/...`, `spdl/autoresearch/_app/...`, `spdl/autoresearch/_common/fb/...`, `spdl/autoresearch/core/...`, `spdl/autoresearch/pipeline_optimization/...`) updated to point to the new per-module test paths. - `fbcode/spdl/PACKAGE` comments updated to reference the new `tests/` paths. - `fbcode/spdl/.llms/skills/code-authoring/SKILL.md` updated to describe the new layout convention. - GitHub workflows (`_build_linux.yml`, `_build_linux_cuda.yml`, `_build_macos.yml`, `_build_windows.yml`) updated so each pytest invocation lists the new per-module paths under the OSS `src/spdl/` prefix; `docs.yml` `paths-ignore` updated to `src/spdl/**/tests/**`. - Hydra `_target_` string in `pipeline_hydra_test.py` updated from `spdl.tests.pipeline.fb...` to `spdl.pipeline.tests.fb...`. Differential Revision: D107140706
moto-meta
force-pushed
the
export-D107140706
branch
from
4a2236d to
5b7885b
Compare
moto-meta
pushed a commit
that referenced
this pull request
Jun 2, 2026
Summary: Pull Request resolved: #1500 Reorganize SPDL tests so each module owns its own tests. Tests previously lived under `fbcode/spdl/tests/<module>/` and depended on a shared root for fixtures and Buck macros. After this change, each module's tests live in `<module>/tests/`, which makes `buck test fbcode//spdl/<module>/...` run every test for that module without enumerating sibling test paths. New layout: - `spdl/io/tests/` (was `spdl/tests/io/`) — also hosts the shared `fixture.py` + `fb/__init__.py` (FFmpeg helpers), since only `io` and `cuda` tests use them and `cuda` tests already depend only on `spdl.io`. - `spdl/cuda/tests/` (was `spdl/tests/cuda/`) — `PACKAGE` moved with it; depends on `//spdl/io/tests:fixture` and imports `from spdl.io.tests.fixture`. - `spdl/pipeline/tests/` (was `spdl/tests/pipeline/`, including `fb/`). - `spdl/dataloader/tests/` (was `spdl/tests/dataloader/`). - `spdl/autoresearch/tests/` (was `spdl/tests/autoresearch/`, including `fb/`). - `spdl/def.bzl` — new file holding the `spdl_tests_with_ffmpeg_variants` and `spdl_tests_with_python_variants` macros that were previously in `spdl/tests/def.bzl`. - `fbcode/spdl/tests/` deleted entirely. Other updates: - `from ..fixture` (relative) is now `from .fixture` for `io` tests and `from spdl.io.tests.fixture` (absolute) for `cuda` tests. - `spdl.io.tests/fb/__init__.py` resolves the FFmpeg resource via `importlib.resources.path("spdl.io.tests", "ffmpeg")`. - Visibility lists in module BUCKs (`spdl/io/...`, `spdl/io/lib/...`, `spdl/io/utils/...`, `spdl/pipeline/...`, `spdl/pipeline/_iter_utils/...`, `spdl/pipeline/fb/...`, `spdl/pipeline/fb/lib/...`, `spdl/autoresearch/...`, `spdl/autoresearch/_app/...`, `spdl/autoresearch/_common/fb/...`, `spdl/autoresearch/core/...`, `spdl/autoresearch/pipeline_optimization/...`) updated to point to the new per-module test paths. - `fbcode/spdl/PACKAGE` comments updated to reference the new `tests/` paths. - `fbcode/spdl/.llms/skills/code-authoring/SKILL.md` updated to describe the new layout convention. - GitHub workflows (`_build_linux.yml`, `_build_linux_cuda.yml`, `_build_macos.yml`, `_build_windows.yml`) updated so each pytest invocation lists the new per-module paths under the OSS `src/spdl/` prefix; `docs.yml` `paths-ignore` updated to `src/spdl/**/tests/**`. - Hydra `_target_` string in `pipeline_hydra_test.py` updated from `spdl.tests.pipeline.fb...` to `spdl.pipeline.tests.fb...`. Differential Revision: D107140706
moto-meta
force-pushed
the
export-D107140706
branch
from
5b7885b to
b825e0a
Compare
moto-meta
pushed a commit
that referenced
this pull request
Jun 2, 2026
Summary: Pull Request resolved: #1500 Reorganize SPDL tests so each module owns its own tests. Tests previously lived under `fbcode/spdl/tests/<module>/` and depended on a shared root for fixtures and Buck macros. After this change, each module's tests live in `<module>/tests/`, which makes `buck test fbcode//spdl/<module>/...` run every test for that module without enumerating sibling test paths. New layout: - `spdl/io/tests/` (was `spdl/tests/io/`) — also hosts the shared `fixture.py` + `fb/__init__.py` (FFmpeg helpers), since only `io` and `cuda` tests use them and `cuda` tests already depend only on `spdl.io`. - `spdl/cuda/tests/` (was `spdl/tests/cuda/`) — `PACKAGE` moved with it; depends on `//spdl/io/tests:fixture` and imports `from spdl.io.tests.fixture`. - `spdl/pipeline/tests/` (was `spdl/tests/pipeline/`, including `fb/`). - `spdl/dataloader/tests/` (was `spdl/tests/dataloader/`). - `spdl/autoresearch/tests/` (was `spdl/tests/autoresearch/`, including `fb/`). - `spdl/def.bzl` — new file holding the `spdl_tests_with_ffmpeg_variants` and `spdl_tests_with_python_variants` macros that were previously in `spdl/tests/def.bzl`. - `fbcode/spdl/tests/` deleted entirely. Other updates: - `from ..fixture` (relative) is now `from .fixture` for `io` tests and `from spdl.io.tests.fixture` (absolute) for `cuda` tests. - `spdl.io.tests/fb/__init__.py` resolves the FFmpeg resource via `importlib.resources.path("spdl.io.tests", "ffmpeg")`. - Visibility lists in module BUCKs (`spdl/io/...`, `spdl/io/lib/...`, `spdl/io/utils/...`, `spdl/pipeline/...`, `spdl/pipeline/_iter_utils/...`, `spdl/pipeline/fb/...`, `spdl/pipeline/fb/lib/...`, `spdl/autoresearch/...`, `spdl/autoresearch/_app/...`, `spdl/autoresearch/_common/fb/...`, `spdl/autoresearch/core/...`, `spdl/autoresearch/pipeline_optimization/...`) updated to point to the new per-module test paths. - `fbcode/spdl/PACKAGE` comments updated to reference the new `tests/` paths. - `fbcode/spdl/.llms/skills/code-authoring/SKILL.md` updated to describe the new layout convention. - GitHub workflows (`_build_linux.yml`, `_build_linux_cuda.yml`, `_build_macos.yml`, `_build_windows.yml`) updated so each pytest invocation lists the new per-module paths under the OSS `src/spdl/` prefix; `docs.yml` `paths-ignore` updated to `src/spdl/**/tests/**`. - Hydra `_target_` string in `pipeline_hydra_test.py` updated from `spdl.tests.pipeline.fb...` to `spdl.pipeline.tests.fb...`. Differential Revision: D107140706
moto-meta
force-pushed
the
export-D107140706
branch
from
b825e0a to
34455ed
Compare
moto-meta
pushed a commit
that referenced
this pull request
Jun 2, 2026
Summary: Pull Request resolved: #1500 Reorganize SPDL tests so each module owns its own tests. Tests previously lived under `fbcode/spdl/tests/<module>/` and depended on a shared root for fixtures and Buck macros. After this change, each module's tests live in `<module>/tests/`, which makes `buck test fbcode//spdl/<module>/...` run every test for that module without enumerating sibling test paths. New layout: - `spdl/io/tests/` (was `spdl/tests/io/`) — also hosts the shared `fixture.py` + `fb/__init__.py` (FFmpeg helpers), since only `io` and `cuda` tests use them and `cuda` tests already depend only on `spdl.io`. - `spdl/cuda/tests/` (was `spdl/tests/cuda/`) — `PACKAGE` moved with it; depends on `//spdl/io/tests:fixture` and imports `from spdl.io.tests.fixture`. - `spdl/pipeline/tests/` (was `spdl/tests/pipeline/`, including `fb/`). - `spdl/dataloader/tests/` (was `spdl/tests/dataloader/`). - `spdl/autoresearch/tests/` (was `spdl/tests/autoresearch/`, including `fb/`). - `spdl/def.bzl` — new file holding the `spdl_tests_with_ffmpeg_variants` and `spdl_tests_with_python_variants` macros that were previously in `spdl/tests/def.bzl`. - `fbcode/spdl/tests/` deleted entirely. Other updates: - `from ..fixture` (relative) is now `from .fixture` for `io` tests and `from spdl.io.tests.fixture` (absolute) for `cuda` tests. - `spdl.io.tests/fb/__init__.py` resolves the FFmpeg resource via `importlib.resources.path("spdl.io.tests", "ffmpeg")`. - Visibility lists in module BUCKs (`spdl/io/...`, `spdl/io/lib/...`, `spdl/io/utils/...`, `spdl/pipeline/...`, `spdl/pipeline/_iter_utils/...`, `spdl/pipeline/fb/...`, `spdl/pipeline/fb/lib/...`, `spdl/autoresearch/...`, `spdl/autoresearch/_app/...`, `spdl/autoresearch/_common/fb/...`, `spdl/autoresearch/core/...`, `spdl/autoresearch/pipeline_optimization/...`) updated to point to the new per-module test paths. - `fbcode/spdl/PACKAGE` comments updated to reference the new `tests/` paths. - `fbcode/spdl/.llms/skills/code-authoring/SKILL.md` updated to describe the new layout convention. - GitHub workflows (`_build_linux.yml`, `_build_linux_cuda.yml`, `_build_macos.yml`, `_build_windows.yml`) updated so each pytest invocation lists the new per-module paths under the OSS `src/spdl/` prefix; `docs.yml` `paths-ignore` updated to `src/spdl/**/tests/**`. - Hydra `_target_` string in `pipeline_hydra_test.py` updated from `spdl.tests.pipeline.fb...` to `spdl.pipeline.tests.fb...`. Differential Revision: D107140706
moto-meta
force-pushed
the
export-D107140706
branch
from
34455ed to
24d4421
Compare
moto-meta
pushed a commit
that referenced
this pull request
Jun 2, 2026
Summary: Pull Request resolved: #1500 Reorganize SPDL tests so each module owns its own tests. Tests previously lived under `fbcode/spdl/tests/<module>/` and depended on a shared root for fixtures and Buck macros. After this change, each module's tests live in `<module>/tests/`, which makes `buck test fbcode//spdl/<module>/...` run every test for that module without enumerating sibling test paths. New layout: - `spdl/io/tests/` (was `spdl/tests/io/`) — also hosts the shared `fixture.py` + `fb/__init__.py` (FFmpeg helpers), since only `io` and `cuda` tests use them and `cuda` tests already depend only on `spdl.io`. - `spdl/cuda/tests/` (was `spdl/tests/cuda/`) — `PACKAGE` moved with it; depends on `//spdl/io/tests:fixture` and imports `from spdl.io.tests.fixture`. - `spdl/pipeline/tests/` (was `spdl/tests/pipeline/`, including `fb/`). - `spdl/dataloader/tests/` (was `spdl/tests/dataloader/`). - `spdl/autoresearch/tests/` (was `spdl/tests/autoresearch/`, including `fb/`). - `spdl/def.bzl` — new file holding the `spdl_tests_with_ffmpeg_variants` and `spdl_tests_with_python_variants` macros that were previously in `spdl/tests/def.bzl`. - `fbcode/spdl/tests/` deleted entirely. Other updates: - `from ..fixture` (relative) is now `from .fixture` for `io` tests and `from spdl.io.tests.fixture` (absolute) for `cuda` tests. - `spdl.io.tests/fb/__init__.py` resolves the FFmpeg resource via `importlib.resources.path("spdl.io.tests", "ffmpeg")`. - Visibility lists in module BUCKs (`spdl/io/...`, `spdl/io/lib/...`, `spdl/io/utils/...`, `spdl/pipeline/...`, `spdl/pipeline/_iter_utils/...`, `spdl/pipeline/fb/...`, `spdl/pipeline/fb/lib/...`, `spdl/autoresearch/...`, `spdl/autoresearch/_app/...`, `spdl/autoresearch/_common/fb/...`, `spdl/autoresearch/core/...`, `spdl/autoresearch/pipeline_optimization/...`) updated to point to the new per-module test paths. - `fbcode/spdl/PACKAGE` comments updated to reference the new `tests/` paths. - `fbcode/spdl/.llms/skills/code-authoring/SKILL.md` updated to describe the new layout convention. - GitHub workflows (`_build_linux.yml`, `_build_linux_cuda.yml`, `_build_macos.yml`, `_build_windows.yml`) updated so each pytest invocation lists the new per-module paths under the OSS `src/spdl/` prefix; `docs.yml` `paths-ignore` updated to `src/spdl/**/tests/**`. - Hydra `_target_` string in `pipeline_hydra_test.py` updated from `spdl.tests.pipeline.fb...` to `spdl.pipeline.tests.fb...`. Differential Revision: D107140706
moto-meta
force-pushed
the
export-D107140706
branch
from
24d4421 to
6594150
Compare
moto-meta
pushed a commit
that referenced
this pull request
Jun 2, 2026
Summary: Pull Request resolved: #1500 Reorganize SPDL tests so each module owns its own tests. Tests previously lived under `fbcode/spdl/tests/<module>/` and depended on a shared root for fixtures and Buck macros. After this change, each module's tests live in `<module>/tests/`, which makes `buck test fbcode//spdl/<module>/...` run every test for that module without enumerating sibling test paths. New layout: - `spdl/io/tests/` (was `spdl/tests/io/`) — also hosts the shared `fixture.py` + `fb/__init__.py` (FFmpeg helpers), since only `io` and `cuda` tests use them and `cuda` tests already depend only on `spdl.io`. - `spdl/cuda/tests/` (was `spdl/tests/cuda/`) — `PACKAGE` moved with it; depends on `//spdl/io/tests:fixture` and imports `from spdl.io.tests.fixture`. - `spdl/pipeline/tests/` (was `spdl/tests/pipeline/`, including `fb/`). - `spdl/dataloader/tests/` (was `spdl/tests/dataloader/`). - `spdl/autoresearch/tests/` (was `spdl/tests/autoresearch/`, including `fb/`). - `spdl/def.bzl` — new file holding the `spdl_tests_with_ffmpeg_variants` and `spdl_tests_with_python_variants` macros that were previously in `spdl/tests/def.bzl`. - `fbcode/spdl/tests/` deleted entirely. Other updates: - `from ..fixture` (relative) is now `from .fixture` for `io` tests and `from spdl.io.tests.fixture` (absolute) for `cuda` tests. - `spdl.io.tests/fb/__init__.py` resolves the FFmpeg resource via `importlib.resources.path("spdl.io.tests", "ffmpeg")`. - Visibility lists in module BUCKs (`spdl/io/...`, `spdl/io/lib/...`, `spdl/io/utils/...`, `spdl/pipeline/...`, `spdl/pipeline/_iter_utils/...`, `spdl/pipeline/fb/...`, `spdl/pipeline/fb/lib/...`, `spdl/autoresearch/...`, `spdl/autoresearch/_app/...`, `spdl/autoresearch/_common/fb/...`, `spdl/autoresearch/core/...`, `spdl/autoresearch/pipeline_optimization/...`) updated to point to the new per-module test paths. - `fbcode/spdl/PACKAGE` comments updated to reference the new `tests/` paths. - `fbcode/spdl/.llms/skills/code-authoring/SKILL.md` updated to describe the new layout convention. - GitHub workflows (`_build_linux.yml`, `_build_linux_cuda.yml`, `_build_macos.yml`, `_build_windows.yml`) updated so each pytest invocation lists the new per-module paths under the OSS `src/spdl/` prefix; `docs.yml` `paths-ignore` updated to `src/spdl/**/tests/**`. - Hydra `_target_` string in `pipeline_hydra_test.py` updated from `spdl.tests.pipeline.fb...` to `spdl.pipeline.tests.fb...`. Differential Revision: D107140706
moto-meta
force-pushed
the
export-D107140706
branch
from
6594150 to
f78a0f8
Compare
moto-meta
pushed a commit
that referenced
this pull request
Jun 2, 2026
Summary: Pull Request resolved: #1500 Reorganize SPDL tests so each module owns its own tests. Tests previously lived under `fbcode/spdl/tests/<module>/` and depended on a shared root for fixtures and Buck macros. After this change, each module's tests live in `<module>/tests/`, which makes `buck test fbcode//spdl/<module>/...` run every test for that module without enumerating sibling test paths. New layout: - `spdl/io/tests/` (was `spdl/tests/io/`) — also hosts the shared `fixture.py` + `fb/__init__.py` (FFmpeg helpers), since only `io` and `cuda` tests use them and `cuda` tests already depend only on `spdl.io`. - `spdl/cuda/tests/` (was `spdl/tests/cuda/`) — `PACKAGE` moved with it; depends on `//spdl/io/tests:fixture` and imports `from spdl.io.tests.fixture`. - `spdl/pipeline/tests/` (was `spdl/tests/pipeline/`, including `fb/`). - `spdl/dataloader/tests/` (was `spdl/tests/dataloader/`). - `spdl/autoresearch/tests/` (was `spdl/tests/autoresearch/`, including `fb/`). - `spdl/def.bzl` — new file holding the `spdl_tests_with_ffmpeg_variants` and `spdl_tests_with_python_variants` macros that were previously in `spdl/tests/def.bzl`. - `fbcode/spdl/tests/` deleted entirely. Other updates: - `from ..fixture` (relative) is now `from .fixture` for `io` tests and `from spdl.io.tests.fixture` (absolute) for `cuda` tests. - `spdl.io.tests/fb/__init__.py` resolves the FFmpeg resource via `importlib.resources.path("spdl.io.tests", "ffmpeg")`. - Visibility lists in module BUCKs (`spdl/io/...`, `spdl/io/lib/...`, `spdl/io/utils/...`, `spdl/pipeline/...`, `spdl/pipeline/_iter_utils/...`, `spdl/pipeline/fb/...`, `spdl/pipeline/fb/lib/...`, `spdl/autoresearch/...`, `spdl/autoresearch/_app/...`, `spdl/autoresearch/_common/fb/...`, `spdl/autoresearch/core/...`, `spdl/autoresearch/pipeline_optimization/...`) updated to point to the new per-module test paths. - `fbcode/spdl/PACKAGE` comments updated to reference the new `tests/` paths. - `fbcode/spdl/.llms/skills/code-authoring/SKILL.md` updated to describe the new layout convention. - GitHub workflows (`_build_linux.yml`, `_build_linux_cuda.yml`, `_build_macos.yml`, `_build_windows.yml`) updated so each pytest invocation lists the new per-module paths under the OSS `src/spdl/` prefix; `docs.yml` `paths-ignore` updated to `src/spdl/**/tests/**`. - Hydra `_target_` string in `pipeline_hydra_test.py` updated from `spdl.tests.pipeline.fb...` to `spdl.pipeline.tests.fb...`. Differential Revision: D107140706
moto-meta
force-pushed
the
export-D107140706
branch
from
f78a0f8 to
5e62f5c
Compare
moto-meta
pushed a commit
that referenced
this pull request
Jun 2, 2026
Summary: Pull Request resolved: #1500 Reorganize SPDL tests so each module owns its own tests. Tests previously lived under `fbcode/spdl/tests/<module>/` and depended on a shared root for fixtures and Buck macros. After this change, each module's tests live in `<module>/tests/`, which makes `buck test fbcode//spdl/<module>/...` run every test for that module without enumerating sibling test paths. New layout: - `spdl/io/tests/` (was `spdl/tests/io/`) — also hosts the shared `fixture.py` + `fb/__init__.py` (FFmpeg helpers), since only `io` and `cuda` tests use them and `cuda` tests already depend only on `spdl.io`. - `spdl/cuda/tests/` (was `spdl/tests/cuda/`) — `PACKAGE` moved with it; depends on `//spdl/io/tests:fixture` and imports `from spdl.io.tests.fixture`. - `spdl/pipeline/tests/` (was `spdl/tests/pipeline/`, including `fb/`). - `spdl/dataloader/tests/` (was `spdl/tests/dataloader/`). - `spdl/autoresearch/tests/` (was `spdl/tests/autoresearch/`, including `fb/`). - `spdl/def.bzl` — new file holding the `spdl_tests_with_ffmpeg_variants` and `spdl_tests_with_python_variants` macros that were previously in `spdl/tests/def.bzl`. - `fbcode/spdl/tests/` deleted entirely. Other updates: - `from ..fixture` (relative) is now `from .fixture` for `io` tests and `from spdl.io.tests.fixture` (absolute) for `cuda` tests. - `spdl.io.tests/fb/__init__.py` resolves the FFmpeg resource via `importlib.resources.path("spdl.io.tests", "ffmpeg")`. - Visibility lists in module BUCKs (`spdl/io/...`, `spdl/io/lib/...`, `spdl/io/utils/...`, `spdl/pipeline/...`, `spdl/pipeline/_iter_utils/...`, `spdl/pipeline/fb/...`, `spdl/pipeline/fb/lib/...`, `spdl/autoresearch/...`, `spdl/autoresearch/_app/...`, `spdl/autoresearch/_common/fb/...`, `spdl/autoresearch/core/...`, `spdl/autoresearch/pipeline_optimization/...`) updated to point to the new per-module test paths. - `fbcode/spdl/PACKAGE` comments updated to reference the new `tests/` paths. - `fbcode/spdl/.llms/skills/code-authoring/SKILL.md` updated to describe the new layout convention. - GitHub workflows (`_build_linux.yml`, `_build_linux_cuda.yml`, `_build_macos.yml`, `_build_windows.yml`) updated so each pytest invocation lists the new per-module paths under the OSS `src/spdl/` prefix; `docs.yml` `paths-ignore` updated to `src/spdl/**/tests/**`. - Hydra `_target_` string in `pipeline_hydra_test.py` updated from `spdl.tests.pipeline.fb...` to `spdl.pipeline.tests.fb...`. Differential Revision: D107140706
moto-meta
force-pushed
the
export-D107140706
branch
from
5e62f5c to
d7143f3
Compare
moto-meta
pushed a commit
that referenced
this pull request
Jun 2, 2026
Summary: Pull Request resolved: #1500 Reorganize SPDL tests so each module owns its own tests. Tests previously lived under `fbcode/spdl/tests/<module>/` and depended on a shared root for fixtures and Buck macros. After this change, each module's tests live in `<module>/tests/`, which makes `buck test fbcode//spdl/<module>/...` run every test for that module without enumerating sibling test paths. New layout: - `spdl/io/tests/` (was `spdl/tests/io/`) — also hosts the shared `fixture.py` + `fb/__init__.py` (FFmpeg helpers), since only `io` and `cuda` tests use them and `cuda` tests already depend only on `spdl.io`. - `spdl/cuda/tests/` (was `spdl/tests/cuda/`) — `PACKAGE` moved with it; depends on `//spdl/io/tests:fixture` and imports `from spdl.io.tests.fixture`. - `spdl/pipeline/tests/` (was `spdl/tests/pipeline/`, including `fb/`). - `spdl/dataloader/tests/` (was `spdl/tests/dataloader/`). - `spdl/autoresearch/tests/` (was `spdl/tests/autoresearch/`, including `fb/`). - `spdl/def.bzl` — new file holding the `spdl_tests_with_ffmpeg_variants` and `spdl_tests_with_python_variants` macros that were previously in `spdl/tests/def.bzl`. - `fbcode/spdl/tests/` deleted entirely. Other updates: - `from ..fixture` (relative) is now `from .fixture` for `io` tests and `from spdl.io.tests.fixture` (absolute) for `cuda` tests. - `spdl.io.tests/fb/__init__.py` resolves the FFmpeg resource via `importlib.resources.path("spdl.io.tests", "ffmpeg")`. - Visibility lists in module BUCKs (`spdl/io/...`, `spdl/io/lib/...`, `spdl/io/utils/...`, `spdl/pipeline/...`, `spdl/pipeline/_iter_utils/...`, `spdl/pipeline/fb/...`, `spdl/pipeline/fb/lib/...`, `spdl/autoresearch/...`, `spdl/autoresearch/_app/...`, `spdl/autoresearch/_common/fb/...`, `spdl/autoresearch/core/...`, `spdl/autoresearch/pipeline_optimization/...`) updated to point to the new per-module test paths. - `fbcode/spdl/PACKAGE` comments updated to reference the new `tests/` paths. - `fbcode/spdl/.llms/skills/code-authoring/SKILL.md` updated to describe the new layout convention. - GitHub workflows (`_build_linux.yml`, `_build_linux_cuda.yml`, `_build_macos.yml`, `_build_windows.yml`) updated so each pytest invocation lists the new per-module paths under the OSS `src/spdl/` prefix; `docs.yml` `paths-ignore` updated to `src/spdl/**/tests/**`. - Hydra `_target_` string in `pipeline_hydra_test.py` updated from `spdl.tests.pipeline.fb...` to `spdl.pipeline.tests.fb...`. Differential Revision: D107140706
moto-meta
force-pushed
the
export-D107140706
branch
from
d7143f3 to
7c1afe2
Compare
moto-meta
pushed a commit
that referenced
this pull request
Jun 2, 2026
Summary: Pull Request resolved: #1500 Reorganize SPDL tests so each module owns its own tests. Tests previously lived under `fbcode/spdl/tests/<module>/` and depended on a shared root for fixtures and Buck macros. After this change, each module's tests live in `<module>/tests/`, which makes `buck test fbcode//spdl/<module>/...` run every test for that module without enumerating sibling test paths. New layout: - `spdl/io/tests/` (was `spdl/tests/io/`) — also hosts the shared `fixture.py` + `fb/__init__.py` (FFmpeg helpers), since only `io` and `cuda` tests use them and `cuda` tests already depend only on `spdl.io`. - `spdl/cuda/tests/` (was `spdl/tests/cuda/`) — `PACKAGE` moved with it; depends on `//spdl/io/tests:fixture` and imports `from spdl.io.tests.fixture`. - `spdl/pipeline/tests/` (was `spdl/tests/pipeline/`, including `fb/`). - `spdl/dataloader/tests/` (was `spdl/tests/dataloader/`). - `spdl/autoresearch/tests/` (was `spdl/tests/autoresearch/`, including `fb/`). - `spdl/def.bzl` — new file holding the `spdl_tests_with_ffmpeg_variants` and `spdl_tests_with_python_variants` macros that were previously in `spdl/tests/def.bzl`. - `fbcode/spdl/tests/` deleted entirely. Other updates: - `from ..fixture` (relative) is now `from .fixture` for `io` tests and `from spdl.io.tests.fixture` (absolute) for `cuda` tests. - `spdl.io.tests/fb/__init__.py` resolves the FFmpeg resource via `importlib.resources.path("spdl.io.tests", "ffmpeg")`. - Visibility lists in module BUCKs (`spdl/io/...`, `spdl/io/lib/...`, `spdl/io/utils/...`, `spdl/pipeline/...`, `spdl/pipeline/_iter_utils/...`, `spdl/pipeline/fb/...`, `spdl/pipeline/fb/lib/...`, `spdl/autoresearch/...`, `spdl/autoresearch/_app/...`, `spdl/autoresearch/_common/fb/...`, `spdl/autoresearch/core/...`, `spdl/autoresearch/pipeline_optimization/...`) updated to point to the new per-module test paths. - `fbcode/spdl/PACKAGE` comments updated to reference the new `tests/` paths. - `fbcode/spdl/.llms/skills/code-authoring/SKILL.md` updated to describe the new layout convention. - GitHub workflows (`_build_linux.yml`, `_build_linux_cuda.yml`, `_build_macos.yml`, `_build_windows.yml`) updated so each pytest invocation lists the new per-module paths under the OSS `src/spdl/` prefix; `docs.yml` `paths-ignore` updated to `src/spdl/**/tests/**`. - Hydra `_target_` string in `pipeline_hydra_test.py` updated from `spdl.tests.pipeline.fb...` to `spdl.pipeline.tests.fb...`. Differential Revision: D107140706
moto-meta
force-pushed
the
export-D107140706
branch
from
7c1afe2 to
da58169
Compare
moto-meta
pushed a commit
that referenced
this pull request
Jun 2, 2026
Summary: Pull Request resolved: #1500 Reorganize SPDL tests so each module owns its own tests. Tests previously lived under `fbcode/spdl/tests/<module>/` and depended on a shared root for fixtures and Buck macros. After this change, each module's tests live in `<module>/tests/`, which makes `buck test fbcode//spdl/<module>/...` run every test for that module without enumerating sibling test paths. New layout: - `spdl/io/tests/` (was `spdl/tests/io/`) — also hosts the shared `fixture.py` + `fb/__init__.py` (FFmpeg helpers), since only `io` and `cuda` tests use them and `cuda` tests already depend only on `spdl.io`. - `spdl/cuda/tests/` (was `spdl/tests/cuda/`) — `PACKAGE` moved with it; depends on `//spdl/io/tests:fixture` and imports `from spdl.io.tests.fixture`. - `spdl/pipeline/tests/` (was `spdl/tests/pipeline/`, including `fb/`). - `spdl/dataloader/tests/` (was `spdl/tests/dataloader/`). - `spdl/autoresearch/tests/` (was `spdl/tests/autoresearch/`, including `fb/`). - `spdl/def.bzl` — new file holding the `spdl_tests_with_ffmpeg_variants` and `spdl_tests_with_python_variants` macros that were previously in `spdl/tests/def.bzl`. - `fbcode/spdl/tests/` deleted entirely. Other updates: - `from ..fixture` (relative) is now `from .fixture` for `io` tests and `from spdl.io.tests.fixture` (absolute) for `cuda` tests. - `spdl.io.tests/fb/__init__.py` resolves the FFmpeg resource via `importlib.resources.path("spdl.io.tests", "ffmpeg")`. - Visibility lists in module BUCKs (`spdl/io/...`, `spdl/io/lib/...`, `spdl/io/utils/...`, `spdl/pipeline/...`, `spdl/pipeline/_iter_utils/...`, `spdl/pipeline/fb/...`, `spdl/pipeline/fb/lib/...`, `spdl/autoresearch/...`, `spdl/autoresearch/_app/...`, `spdl/autoresearch/_common/fb/...`, `spdl/autoresearch/core/...`, `spdl/autoresearch/pipeline_optimization/...`) updated to point to the new per-module test paths. - `fbcode/spdl/PACKAGE` comments updated to reference the new `tests/` paths. - `fbcode/spdl/.llms/skills/code-authoring/SKILL.md` updated to describe the new layout convention. - GitHub workflows (`_build_linux.yml`, `_build_linux_cuda.yml`, `_build_macos.yml`, `_build_windows.yml`) updated so each pytest invocation lists the new per-module paths under the OSS `src/spdl/` prefix; `docs.yml` `paths-ignore` updated to `src/spdl/**/tests/**`. - Hydra `_target_` string in `pipeline_hydra_test.py` updated from `spdl.tests.pipeline.fb...` to `spdl.pipeline.tests.fb...`. Differential Revision: D107140706
moto-meta
force-pushed
the
export-D107140706
branch
from
da58169 to
a4f4bfc
Compare
moto-meta
pushed a commit
that referenced
this pull request
Jun 2, 2026
Summary: Pull Request resolved: #1500 Reorganize SPDL tests so each module owns its own tests. Tests previously lived under `fbcode/spdl/tests/<module>/` and depended on a shared root for fixtures and Buck macros. After this change, each module's tests live in `<module>/tests/`, which makes `buck test fbcode//spdl/<module>/...` run every test for that module without enumerating sibling test paths. New layout: - `spdl/io/tests/` (was `spdl/tests/io/`) — also hosts the shared `fixture.py` + `fb/__init__.py` (FFmpeg helpers), since only `io` and `cuda` tests use them and `cuda` tests already depend only on `spdl.io`. - `spdl/cuda/tests/` (was `spdl/tests/cuda/`) — `PACKAGE` moved with it; depends on `//spdl/io/tests:fixture` and imports `from spdl.io.tests.fixture`. - `spdl/pipeline/tests/` (was `spdl/tests/pipeline/`, including `fb/`). - `spdl/dataloader/tests/` (was `spdl/tests/dataloader/`). - `spdl/autoresearch/tests/` (was `spdl/tests/autoresearch/`, including `fb/`). - `spdl/def.bzl` — new file holding the `spdl_tests_with_ffmpeg_variants` and `spdl_tests_with_python_variants` macros that were previously in `spdl/tests/def.bzl`. - `fbcode/spdl/tests/` deleted entirely. Other updates: - `from ..fixture` (relative) is now `from .fixture` for `io` tests and `from spdl.io.tests.fixture` (absolute) for `cuda` tests. - `spdl.io.tests/fb/__init__.py` resolves the FFmpeg resource via `importlib.resources.path("spdl.io.tests", "ffmpeg")`. - Visibility lists in module BUCKs (`spdl/io/...`, `spdl/io/lib/...`, `spdl/io/utils/...`, `spdl/pipeline/...`, `spdl/pipeline/_iter_utils/...`, `spdl/pipeline/fb/...`, `spdl/pipeline/fb/lib/...`, `spdl/autoresearch/...`, `spdl/autoresearch/_app/...`, `spdl/autoresearch/_common/fb/...`, `spdl/autoresearch/core/...`, `spdl/autoresearch/pipeline_optimization/...`) updated to point to the new per-module test paths. - `fbcode/spdl/PACKAGE` comments updated to reference the new `tests/` paths. - `fbcode/spdl/.llms/skills/code-authoring/SKILL.md` updated to describe the new layout convention. - GitHub workflows (`_build_linux.yml`, `_build_linux_cuda.yml`, `_build_macos.yml`, `_build_windows.yml`) updated so each pytest invocation lists the new per-module paths under the OSS `src/spdl/` prefix; `docs.yml` `paths-ignore` updated to `src/spdl/**/tests/**`. - Hydra `_target_` string in `pipeline_hydra_test.py` updated from `spdl.tests.pipeline.fb...` to `spdl.pipeline.tests.fb...`. Differential Revision: D107140706
moto-meta
force-pushed
the
export-D107140706
branch
from
a4f4bfc to
8136135
Compare
moto-meta
pushed a commit
that referenced
this pull request
Jun 2, 2026
Summary: Pull Request resolved: #1500 Reorganize SPDL tests so each module owns its own tests. Tests previously lived under `fbcode/spdl/tests/<module>/` and depended on a shared root for fixtures and Buck macros. After this change, each module's tests live in `<module>/tests/`, which makes `buck test fbcode//spdl/<module>/...` run every test for that module without enumerating sibling test paths. New layout: - `spdl/io/tests/` (was `spdl/tests/io/`) — also hosts the shared `fixture.py` + `fb/__init__.py` (FFmpeg helpers), since only `io` and `cuda` tests use them and `cuda` tests already depend only on `spdl.io`. - `spdl/cuda/tests/` (was `spdl/tests/cuda/`) — `PACKAGE` moved with it; depends on `//spdl/io/tests:fixture` and imports `from spdl.io.tests.fixture`. - `spdl/pipeline/tests/` (was `spdl/tests/pipeline/`, including `fb/`). - `spdl/dataloader/tests/` (was `spdl/tests/dataloader/`). - `spdl/autoresearch/tests/` (was `spdl/tests/autoresearch/`, including `fb/`). - `spdl/def.bzl` — new file holding the `spdl_tests_with_ffmpeg_variants` and `spdl_tests_with_python_variants` macros that were previously in `spdl/tests/def.bzl`. - `fbcode/spdl/tests/` deleted entirely. Other updates: - `from ..fixture` (relative) is now `from .fixture` for `io` tests and `from spdl.io.tests.fixture` (absolute) for `cuda` tests. - `spdl.io.tests/fb/__init__.py` resolves the FFmpeg resource via `importlib.resources.path("spdl.io.tests", "ffmpeg")`. - Visibility lists in module BUCKs (`spdl/io/...`, `spdl/io/lib/...`, `spdl/io/utils/...`, `spdl/pipeline/...`, `spdl/pipeline/_iter_utils/...`, `spdl/pipeline/fb/...`, `spdl/pipeline/fb/lib/...`, `spdl/autoresearch/...`, `spdl/autoresearch/_app/...`, `spdl/autoresearch/_common/fb/...`, `spdl/autoresearch/core/...`, `spdl/autoresearch/pipeline_optimization/...`) updated to point to the new per-module test paths. - `fbcode/spdl/PACKAGE` comments updated to reference the new `tests/` paths. - `fbcode/spdl/.llms/skills/code-authoring/SKILL.md` updated to describe the new layout convention. - GitHub workflows (`_build_linux.yml`, `_build_linux_cuda.yml`, `_build_macos.yml`, `_build_windows.yml`) updated so each pytest invocation lists the new per-module paths under the OSS `src/spdl/` prefix; `docs.yml` `paths-ignore` updated to `src/spdl/**/tests/**`. - Hydra `_target_` string in `pipeline_hydra_test.py` updated from `spdl.tests.pipeline.fb...` to `spdl.pipeline.tests.fb...`. Differential Revision: D107140706
moto-meta
force-pushed
the
export-D107140706
branch
from
8136135 to
6f34a68
Compare
moto-meta
pushed a commit
that referenced
this pull request
Jun 2, 2026
Summary: Pull Request resolved: #1500 Reorganize SPDL tests so each module owns its own tests. Tests previously lived under `fbcode/spdl/tests/<module>/` and depended on a shared root for fixtures and Buck macros. After this change, each module's tests live in `<module>/tests/`, which makes `buck test fbcode//spdl/<module>/...` run every test for that module without enumerating sibling test paths. New layout: - `spdl/io/tests/` (was `spdl/tests/io/`) — also hosts the shared `fixture.py` + `fb/__init__.py` (FFmpeg helpers), since only `io` and `cuda` tests use them and `cuda` tests already depend only on `spdl.io`. - `spdl/cuda/tests/` (was `spdl/tests/cuda/`) — `PACKAGE` moved with it; depends on `//spdl/io/tests:fixture` and imports `from spdl.io.tests.fixture`. - `spdl/pipeline/tests/` (was `spdl/tests/pipeline/`, including `fb/`). - `spdl/dataloader/tests/` (was `spdl/tests/dataloader/`). - `spdl/autoresearch/tests/` (was `spdl/tests/autoresearch/`, including `fb/`). - `spdl/def.bzl` — new file holding the `spdl_tests_with_ffmpeg_variants` and `spdl_tests_with_python_variants` macros that were previously in `spdl/tests/def.bzl`. - `fbcode/spdl/tests/` deleted entirely. Other updates: - `from ..fixture` (relative) is now `from .fixture` for `io` tests and `from spdl.io.tests.fixture` (absolute) for `cuda` tests. - `spdl.io.tests/fb/__init__.py` resolves the FFmpeg resource via `importlib.resources.path("spdl.io.tests", "ffmpeg")`. - Visibility lists in module BUCKs (`spdl/io/...`, `spdl/io/lib/...`, `spdl/io/utils/...`, `spdl/pipeline/...`, `spdl/pipeline/_iter_utils/...`, `spdl/pipeline/fb/...`, `spdl/pipeline/fb/lib/...`, `spdl/autoresearch/...`, `spdl/autoresearch/_app/...`, `spdl/autoresearch/_common/fb/...`, `spdl/autoresearch/core/...`, `spdl/autoresearch/pipeline_optimization/...`) updated to point to the new per-module test paths. - `fbcode/spdl/PACKAGE` comments updated to reference the new `tests/` paths. - `fbcode/spdl/.llms/skills/code-authoring/SKILL.md` updated to describe the new layout convention. - GitHub workflows (`_build_linux.yml`, `_build_linux_cuda.yml`, `_build_macos.yml`, `_build_windows.yml`) updated so each pytest invocation lists the new per-module paths under the OSS `src/spdl/` prefix; `docs.yml` `paths-ignore` updated to `src/spdl/**/tests/**`. - Hydra `_target_` string in `pipeline_hydra_test.py` updated from `spdl.tests.pipeline.fb...` to `spdl.pipeline.tests.fb...`. Differential Revision: D107140706
moto-meta
force-pushed
the
export-D107140706
branch
from
6f34a68 to
3771964
Compare
moto-meta
pushed a commit
that referenced
this pull request
Jun 2, 2026
Summary: Pull Request resolved: #1500 Reorganize SPDL tests so each module owns its own tests. Tests previously lived under `fbcode/spdl/tests/<module>/` and depended on a shared root for fixtures and Buck macros. After this change, each module's tests live in `<module>/tests/`, which makes `buck test fbcode//spdl/<module>/...` run every test for that module without enumerating sibling test paths. New layout: - `spdl/io/tests/` (was `spdl/tests/io/`) — also hosts the shared `fixture.py` + `fb/__init__.py` (FFmpeg helpers), since only `io` and `cuda` tests use them and `cuda` tests already depend only on `spdl.io`. - `spdl/cuda/tests/` (was `spdl/tests/cuda/`) — `PACKAGE` moved with it; depends on `//spdl/io/tests:fixture` and imports `from spdl.io.tests.fixture`. - `spdl/pipeline/tests/` (was `spdl/tests/pipeline/`, including `fb/`). - `spdl/dataloader/tests/` (was `spdl/tests/dataloader/`). - `spdl/autoresearch/tests/` (was `spdl/tests/autoresearch/`, including `fb/`). - `spdl/def.bzl` — new file holding the `spdl_tests_with_ffmpeg_variants` and `spdl_tests_with_python_variants` macros that were previously in `spdl/tests/def.bzl`. - `fbcode/spdl/tests/` deleted entirely. Other updates: - `from ..fixture` (relative) is now `from .fixture` for `io` tests and `from spdl.io.tests.fixture` (absolute) for `cuda` tests. - `spdl.io.tests/fb/__init__.py` resolves the FFmpeg resource via `importlib.resources.path("spdl.io.tests", "ffmpeg")`. - Visibility lists in module BUCKs (`spdl/io/...`, `spdl/io/lib/...`, `spdl/io/utils/...`, `spdl/pipeline/...`, `spdl/pipeline/_iter_utils/...`, `spdl/pipeline/fb/...`, `spdl/pipeline/fb/lib/...`, `spdl/autoresearch/...`, `spdl/autoresearch/_app/...`, `spdl/autoresearch/_common/fb/...`, `spdl/autoresearch/core/...`, `spdl/autoresearch/pipeline_optimization/...`) updated to point to the new per-module test paths. - `fbcode/spdl/PACKAGE` comments updated to reference the new `tests/` paths. - `fbcode/spdl/.llms/skills/code-authoring/SKILL.md` updated to describe the new layout convention. - GitHub workflows (`_build_linux.yml`, `_build_linux_cuda.yml`, `_build_macos.yml`, `_build_windows.yml`) updated so each pytest invocation lists the new per-module paths under the OSS `src/spdl/` prefix; `docs.yml` `paths-ignore` updated to `src/spdl/**/tests/**`. - Hydra `_target_` string in `pipeline_hydra_test.py` updated from `spdl.tests.pipeline.fb...` to `spdl.pipeline.tests.fb...`. Differential Revision: D107140706
moto-meta
force-pushed
the
export-D107140706
branch
from
3771964 to
635ac01
Compare
Summary: Pull Request resolved: #1500 Reorganize SPDL tests so each module owns its own tests. Tests previously lived under `fbcode/spdl/tests/<module>/` and depended on a shared root for fixtures and Buck macros. After this change, each module's tests live in `<module>/tests/`, which makes `buck test fbcode//spdl/<module>/...` run every test for that module without enumerating sibling test paths. New layout: - `spdl/io/tests/` (was `spdl/tests/io/`) — also hosts the shared `fixture.py` + `fb/__init__.py` (FFmpeg helpers), since only `io` and `cuda` tests use them and `cuda` tests already depend only on `spdl.io`. - `spdl/cuda/tests/` (was `spdl/tests/cuda/`) — `PACKAGE` moved with it; depends on `//spdl/io/tests:fixture` and imports `from spdl.io.tests.fixture`. - `spdl/pipeline/tests/` (was `spdl/tests/pipeline/`, including `fb/`). - `spdl/dataloader/tests/` (was `spdl/tests/dataloader/`). - `spdl/autoresearch/tests/` (was `spdl/tests/autoresearch/`, including `fb/`). - `spdl/def.bzl` — new file holding the `spdl_tests_with_ffmpeg_variants` and `spdl_tests_with_python_variants` macros that were previously in `spdl/tests/def.bzl`. - `fbcode/spdl/tests/` deleted entirely. Other updates: - `from ..fixture` (relative) is now `from .fixture` for `io` tests and `from spdl.io.tests.fixture` (absolute) for `cuda` tests. - `spdl.io.tests/fb/__init__.py` resolves the FFmpeg resource via `importlib.resources.path("spdl.io.tests", "ffmpeg")`. - Visibility lists in module BUCKs (`spdl/io/...`, `spdl/io/lib/...`, `spdl/io/utils/...`, `spdl/pipeline/...`, `spdl/pipeline/_iter_utils/...`, `spdl/pipeline/fb/...`, `spdl/pipeline/fb/lib/...`, `spdl/autoresearch/...`, `spdl/autoresearch/_app/...`, `spdl/autoresearch/_common/fb/...`, `spdl/autoresearch/core/...`, `spdl/autoresearch/pipeline_optimization/...`) updated to point to the new per-module test paths. - `fbcode/spdl/PACKAGE` comments updated to reference the new `tests/` paths. - `fbcode/spdl/.llms/skills/code-authoring/SKILL.md` updated to describe the new layout convention. - GitHub workflows (`_build_linux.yml`, `_build_linux_cuda.yml`, `_build_macos.yml`, `_build_windows.yml`) updated so each pytest invocation lists the new per-module paths under the OSS `src/spdl/` prefix; `docs.yml` `paths-ignore` updated to `src/spdl/**/tests/**`. - Hydra `_target_` string in `pipeline_hydra_test.py` updated from `spdl.tests.pipeline.fb...` to `spdl.pipeline.tests.fb...`. Differential Revision: D107140706
moto-meta
force-pushed
the
export-D107140706
branch
from
635ac01 to
4e360a5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Reorganize SPDL tests so each module owns its own tests. Tests previously lived under
fbcode/spdl/tests/<module>/and depended on a shared root for fixtures and Buck macros. After this change, each module's tests live in<module>/tests/, which makesbuck test fbcode//spdl/<module>/...run every test for that module without enumerating sibling test paths.New layout:
spdl/io/tests/(wasspdl/tests/io/) — also hosts the sharedfixture.py+fb/__init__.py(FFmpeg helpers), since onlyioandcudatests use them andcudatests already depend only onspdl.io.spdl/cuda/tests/(wasspdl/tests/cuda/) —PACKAGEmoved with it; depends on//spdl/io/tests:fixtureand importsfrom spdl.io.tests.fixture.spdl/pipeline/tests/(wasspdl/tests/pipeline/, includingfb/).spdl/dataloader/tests/(wasspdl/tests/dataloader/).spdl/autoresearch/tests/(wasspdl/tests/autoresearch/, includingfb/).spdl/def.bzl— new file holding thespdl_tests_with_ffmpeg_variantsandspdl_tests_with_python_variantsmacros that were previously inspdl/tests/def.bzl.fbcode/spdl/tests/deleted entirely.Other updates:
from ..fixture(relative) is nowfrom .fixtureforiotests andfrom spdl.io.tests.fixture(absolute) forcudatests.spdl.io.tests/fb/__init__.pyresolves the FFmpeg resource viaimportlib.resources.path("spdl.io.tests", "ffmpeg").spdl/io/...,spdl/io/lib/...,spdl/io/utils/...,spdl/pipeline/...,spdl/pipeline/_iter_utils/...,spdl/pipeline/fb/...,spdl/pipeline/fb/lib/...,spdl/autoresearch/...,spdl/autoresearch/_app/...,spdl/autoresearch/_common/fb/...,spdl/autoresearch/core/...,spdl/autoresearch/pipeline_optimization/...) updated to point to the new per-module test paths.fbcode/spdl/PACKAGEcomments updated to reference the newtests/paths.fbcode/spdl/.llms/skills/code-authoring/SKILL.mdupdated to describe the new layout convention._build_linux.yml,_build_linux_cuda.yml,_build_macos.yml,_build_windows.yml) updated so each pytest invocation lists the new per-module paths under the OSSsrc/spdl/prefix;docs.ymlpaths-ignoreupdated tosrc/spdl/**/tests/**._target_string inpipeline_hydra_test.pyupdated fromspdl.tests.pipeline.fb...tospdl.pipeline.tests.fb....Differential Revision: D107140706