test: cover same field aliased with different arguments#71
Open
fahchen wants to merge 1 commit into
Open
Conversation
Locks in that one field queried twice under distinct aliases with distinct arguments generates independent structs, preserves both argument sets in the printed query, and decodes by alias. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
{ author: user(id: "1") { name email } editor: user(id: "2") { name } }).This behavior was already supported by the existing alias machinery (
field_name/1keys structs by alias, args live onquery_fieldand flow through the Printer); the prior alias test only covered same arguments. No production code changed.Test plan
mix test test/typed_gql/type_generator_test.exs— 22 tests, 0 failuresmix precommit— credo / dialyzer / full suite (655 tests) all green🤖 Generated with Claude Code