fix strict aliasing violations, remove unused libmy files#72
Merged
Conversation
cmikk
approved these changes
Jun 1, 2026
Contributor
cmikk
left a comment
cmikk
left a comment
There was a problem hiding this comment.
Approved, with a note to copy my_format.[ch] to the main libmy and ensure it is in sync with dnstable/libmy.
|
|
||
| return my_bytes_to_hex_str((const uint8_t *) &nval, sizeof(nval), is_upper, dst, dst_size); | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
It appears that only wdns and dnstable use the my_format.[ch] files, and neither use this function, so removing it is appropriate. In general, though, a libmy cleanup should focus on files rather than functions.
These files should be rolled into the main libmy repo, in case we want to use them elsewhere.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.