Skip to content

check norm as class not instance & reset before every epoch instead before every fit #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

check norm as class not instance & reset before every epoch instead before every fit #28

wants to merge 2 commits into from

Conversation

@anubhavmaity
Copy link

@anubhavmaity anubhavmaity commented Mar 31, 2024 •
edited
Loading

Two changes

  • Currently we are passing nn.BatchNorm as class not instance, therefore isinstance will not work. We have to compare nn.BatchNorm as class
  • Currently we reset losses, accuracy, and ns before each fit. It should be done at the start of every epoch instead.

@review-notebook-app
Copy link

review-notebook-app bot commented Mar 31, 2024

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@anubhavmaity anubhavmaity changed the title reset before every epoch instead before every fit check norm as class not instance & reset before every epoch instead before every fit Apr 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@anubhavmaity