This repository was archived by the owner on Feb 2, 2024. It is now read-only.
fix: adding Host header value validation on proxy #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @osvaldo2627 |
climba03003
reviewed
Oct 4, 2021
| @@ -43,6 +44,15 @@ function fastProxy (opts = {}) { | |||
| const sourceHttp2 = req.httpVersionMajor === 2 | |||
| let headers = { ...sourceHttp2 ? filterPseudoHeaders(req.headers) : req.headers } | |||
|
|
|||
| if (!headers.host) { | |||
There was a problem hiding this comment.
Should we check the host if the protocol is http/2 here?
From the document it must be exist for http/1.1. How about http/2?
|
Any update on this? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes/add first level of validation to the Host header value. Without this check, the proxy would throw an internal error if the Host header is missing.
A Host header field must be sent in all HTTP/1.1 request messages. A 400 (Bad Request) status code may be sent to any HTTP/1.1 request message that lacks a Host header field or that contains more than one.
Checklist
npm run testandnpm run benchmarkand the Code of conduct