Fix validate() return type

[flying-sheep]

Checklist

• run npm run test and npm run benchmark
• tests and/or benchmarks are included
• documentation is changed or added
• commit message and code follows the Developer's Certification of Origin
  and the Code of conduct

[mcollina]

Could you add a test to https://github.com/fastify/fastify-basic-auth/blob/master/index.test-d.ts?

[flying-sheep]

all done. I also completely split the possible function signatures.

[mcollina]

should this throw instead?

[climba03003]

The document is using return and it is actually allowed by this line.

fastify-basic-auth/index.js

Line 24 in fdfe2fb

result.then(done, done)

[RafaelGSS]

I would prefer two asserts group instead:

• One returning Promise<Error>
• One returning Promise<void>

[flying-sheep]

Why did the tests not run?

[mcollina]

They did.

There are errors:

  index.test-d.ts:16:4
  ✖  15:44  Parameter username implicitly has an any type.                                                                                               
  ✖  15:54  Parameter password implicitly has an any type.                                                                                               
  ✖  15:64  Parameter req implicitly has an any type.                                                                                                    
  ✖  15:69  Parameter reply implicitly has an any type.                                                                                                  
  ✖  16:4   Parameter type string is not identical to argument type any.                                                                                 
  ✖  17:4   Parameter type string is not identical to argument type any.                                                                                 
  ✖  18:4   Parameter type FastifyRequest<RouteGenericInterface, Server, IncomingMessage> is not identical to argument type any.                         
  ✖  19:4   Parameter type FastifyReply<Server, IncomingMessage, ServerResponse, RouteGenericInterface, unknown> is not identical to argument type any.  

  8 errors

[flying-sheep]

Ah, I guess it’s this one: microsoft/TypeScript#598

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[flying-sheep]

So how do we fix this? I can’t write a test if TypeScript bugs out on me

[mcollina]

cc @fastify/typescript can you help?

[evanshortiss]

@flying-sheep you need to address the type checker error, e.g change validatePromise (username, password, req, reply) to validatePromise (username: string, password: string, req: FastifyRequest, reply: FastifyReply)

[flying-sheep]

Hmm, I thought the whole point of the test was to check if the types get inferred properly …

[evanshortiss]

Wow, sorry, you're right. Looks like an odd TS behaviour.

Not sure what's best here. Perhaps export two definitions?

export type FastifyBasicAuthValidateFnCallback = (username: string, password: string, req: FastifyRequest, reply: FastifyReply, done: (err?: Error) => void) => void
export type FastifyBasicAuthValidateFnPromise = (username: string, password: string, req: FastifyRequest, reply: FastifyReply) => Promise<Error|void>


export interface FastifyBasicAuthOptions {
  validate: FastifyBasicAuthValidateFnPromise|FastifyBasicAuthValidateFnCallback;
  authenticate?: boolean | { realm: string };
  header?: string;
}

This way you can do something like this?

app.register(fastifyBasicAuth, {
  validate: function (username, password, req, reply) {
    return new Promise((resolve, reject) => resolve())
  } as FastifyBasicAuthValidateFnPromise
})

Maybe there's a better solution? I quickly tried conditional types (to return void or a Promise) based on the presence of done, but had some issues getting that to work.

[flying-sheep]

Welp, maybe not possible then. Too bad.

[evanshortiss]

Yeah, seems like it's necessary to explicitly define the type for the Promise-based approach. Exporting those FastifyBasicAuthValidateFnPromise and FastifyBasicAuthValidateFnCallback seems like an alright compromise perhaps?

At least it will provide a hint via intellisense like so:

The test case could become:

app.register(fastifyBasicAuth, {
  validate: function validateCallback (username, password, req, reply) {
    expectType<string>(username)
    expectType<string>(password)
    expectType<FastifyRequest>(req)
    expectType<FastifyReply>(reply)
    return new Promise<void>((resolve, reject) => {resolve()})
  } as FastifyBasicAuthValidateFnPromise,
  header: 'x-forwarded-authorization'
})

[flying-sheep]

Maybe we can get a TypeScript wiz in here to help. It would be great to get it to a state where it’s correct but TypeScript can also infer FastifyBasicAuthValidateFnPromise. As it stands, users have to manually say that, which would be a regression.

I tried this, but it didn’t change anything:

type IsArg5Valid<T extends (...a: any) => any, E> = Parameters<T>['length'] extends 5 ? {} : E;

export interface FastifyBasicAuthOptions {
  validate:
    FastifyBasicAuthValidateFnPromise
    | (FastifyBasicAuthValidateFnCallback & IsArg5Valid<FastifyBasicAuthValidateFnCallback, "You need to specify a “done” callback">);
  ...
}

[fox1t]

I looked into this and I am not sure what is going on. The main issue might be on the FastifyPlugin generic side. I'll look deeper into this ASAP. Thanks for the PR.

[evanshortiss]

This isn't specific to FastifyPlugin AFAICT. Just a quirk of TS. Take a look at this playground example that exhibits the same behaviour. A TypeScript wizard can possibly figure out some clever trick though!