Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: move to node test runner #106

Merged
merged 17 commits into from
Feb 9, 2025
Merged

test: move to node test runner #106

merged 17 commits into from
Feb 9, 2025

Conversation

ilteoood
Copy link
Contributor

@ilteoood ilteoood commented Feb 5, 2025

Checklist

@Fdawgs Fdawgs changed the title feat: move to node test runner test: move to node test runner Feb 7, 2025
@ilteoood
Copy link
Contributor Author

ilteoood commented Feb 7, 2025

@Fdawgs according that fastify v5 works only on Node 20+, should we remove Node 18 from this pipeline?

@Fdawgs Fdawgs requested review from a team and removed request for a team February 7, 2025 11:18
@Fdawgs
Copy link
Member

Fdawgs commented Feb 7, 2025

@ilteoood probably, would need a major release though. @fastify/libraries wdyt?

@jsumners
Copy link
Member

jsumners commented Feb 7, 2025

@ilteoood probably, would need a major release though. @fastify/libraries wdyt?

Sure.

@ilteoood ilteoood requested a review from jsumners February 7, 2025 11:42
@ilteoood ilteoood requested a review from gurgunday February 7, 2025 13:07
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jsumners jsumners merged commit d852829 into fastify:main Feb 9, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants