Point Gemfile.next at Rails 8.1 (8.0 -> 8.1 hop) - #75
Merged
Conversation
Advance the `next?` boot to Rails 8.1 (locked at 8.1.3); the current (`else`) boot stays on 8.0.5. Branches diverge again, so the Style/IdenticalConditionalBranches rubocop:disable wrapper from the cutover is dropped. Detection scan against rails-81-patterns.yml: the only hit across all high/medium patterns (routes-with-array-paths, Benchmark.ms, unsigned_float/decimal, sucker_punch/azure/sidekiq adapters, ActiveSupport::Configurable, mb_chars, ignore_leading_brackets, ...) was `to_time_preserves_timezone`, which we set during the 8.0 hop. Rails 8.1 deprecates `config.active_support.to_time_preserves_timezone` (it becomes the default no-op shim), but Rails 8.0 -- the current boot -- still needs it to silence its own "behavior changes in 8.1" warning. So guard it with `unless NextRails.next?`: set on 8.0, skipped on 8.1. To be removed outright at cutover. Verified on the host (ruby 3.4.9), both boots: - Gemfile.next (8.1.3): dev + prod boot clean, no to_time deprecation (guard skips the line, next?=true), suite green (16 runs, 0 failures). - Gemfile (8.0.5): dev + prod boot clean, to_time line active (next?=false, no 8.0 warning), suite green, rubocop + reek clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Advances the
next?boot to Rails 8.1 (locked at 8.1.3). The current (else) boot stays on 8.0.5. This is the dual-boot hop for 8.0 → 8.1 — the actual cutover comes later once 8.1 is verified in production.Branches diverge again, so the
Style/IdenticalConditionalBranchesrubocop:disable wrapper added during the 8.0 cutover is removed.Detection scan (rails-81-patterns.yml)
Scanned the app against all high/medium patterns — routes-with-array-paths (removed),
Benchmark.ms(removed),unsigned_float/unsigned_decimal,sucker_punch/azure/sidekiqadapters,ActiveSupport::Configurable,mb_chars,ignore_leading_brackets, semicolon query separator. One hit:to_time_preserves_timezone, the line we added during the 8.0 hop.The one change:
to_time_preserves_timezoneRails 8.1 deprecates
config.active_support.to_time_preserves_timezone(it becomes the default; the setter is now a no-op shim). But Rails 8.0 — the current boot — still needs it to silence its "behavior changes in 8.1" warning. So it can't be removed unconditionally during the dual boot.Fix: guard with
NextRails.next?—Set on 8.0, skipped on 8.1. Removed outright at cutover.
Verification (host, ruby 3.4.9, Postgres 16.13) — both boots
next?=true; dev + prod boot clean with noto_timedeprecation (guard skips the line); suite green — 16 runs, 52 assertions, 0 failures.next?=false; dev + prod boot clean with theto_timeline active (no 8.0 warning); suite green; rubocop (42 files) + reek both clean.