Remove orphaned clipboard-rails gem - #80
Merged
Merged
Conversation
clipboard-rails was included via //= require clipboard in the asset manifest but never used: no Clipboard() instantiation, no data-clipboard-* attributes, no copy-to-clipboard wiring anywhere in the app. An orphaned dependency, not a used feature. Dropped both the gem line and the dead manifest require; updated Gemfile.lock and the dual-boot Gemfile.next.lock. Verified: boots, assets precompile without the require, and the full test suite passes (16 runs, 52 assertions, 0 failures).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes the orphaned
clipboard-railsgem.Why
clipboard-railswas pulled into the asset bundle via//= require clipboardinapp/assets/javascripts/application.js, but nothing in the app ever used it:Clipboard()/new Clipboard(...)instantiationdata-clipboard-*attributes in any viewIt is an orphaned dependency (a dead
requirewith no consumer), not a used feature.Changes
gem "clipboard-rails"from theGemfile//= require clipboardline from the asset manifestGemfile.lockand the dual-bootGemfile.next.lockVerification
assets:precompilesucceeds without the require