Unpin concurrent-ruby and update to 1.3.7 (security) - #85
Merged
Conversation
The `< 1.3.5` ceiling was added in the Rails 6.1 era (commit 76656e2) to guard the concurrent-ruby 1.3.5 change that dropped its `logger` dependency and broke Rails < 7.1. On Rails 8.1 that guard is obsolete, and the ceiling was actively holding the app on 1.3.4, which carries CVE-2026-54904/5/6 (fixed in 1.3.7). Replaced the ceiling with a documented `>= 1.3.7` security floor. Used --conservative so nothing else moved (rack stays 2.x). Both lockfiles updated. Verified locally: bundle-audit no longer flags concurrent-ruby; app boots on 1.3.7; test suite green (16 runs, 52 assertions, 0 failures); rubocop + reek clean.
JuanVqz
force-pushed
the
security/unpin-concurrent-ruby
branch
from
July 9, 2026 05:12
3b93b3e to
53f25b0
Compare
JuanVqz
marked this pull request as ready for review
July 9, 2026 05:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Security fix: unpin
concurrent-ruby(< 1.3.5) and update to>= 1.3.7(resolves to 1.3.7).Why
The
< 1.3.5ceiling was added in the Rails 6.1 era (commit76656e2) to guard the concurrent-ruby 1.3.5 change that dropped itsloggerdependency and broke Rails < 7.1. On Rails 8.1 that guard is obsolete — and the ceiling was actively pinning the app to 1.3.4, which carries CVE-2026-54904 / -54905 / -54906 (fixed in 1.3.7). So the pin was doing net harm: no longer protecting anything, and holding three CVEs open.Changes
Gemfile: replacedgem "concurrent-ruby", "< 1.3.5"with a documented>= 1.3.7security floor (comment explains the obsolete guard + the CVEs)Gemfile.lockand the dual-bootGemfile.next.lockupdated (1.3.4 → 1.3.7)--conservativeso nothing else moved (rackstays 2.x)Verification (local)
bundle-audit: concurrent-ruby advisories cleared (no longer flagged)rubocopclean (exact CI config),reekcleanNote
This clears the last of the security advisories in the audit except
webrick(transitive via rackup, no upstream patch yet, low exposure since puma serves production). The puma CVEs are handled in a separate PR.