Skip to content

Conversation

@aniketpalu
Copy link
Contributor

What this PR does / why we need it:

When using a remote offline store with PostgreSQL backend, calling get_historical_features() with start_date and end_date parameters fails with:

TypeError: Got an unexpected keyword argument 'start_date' / 'end_date' for RemoteOfflineStore

The implementation follows the same pattern used by local PostgreSQL based offline stores ensuring consistency across the codebase:

  • Client-side changes (remote.py):

    • Add **kwargs parameter to RemoteOfflineStore.get_historical_features() method signature
    • Extract start_date and end_date from kwargs and serialize them to ISO format strings
    • Include serialized dates in api_parameters for transmission over Arrow Flight
  • Server-side changes (offline_server.py):

    • Extract start_date and end_date from the command dict (if present)
    • Deserialize ISO format strings back to timezone-aware datetime objects
    • Pass extracted dates as **kwargs to the underlying offline store

Which issue(s) this PR fixes:

Misc

@aniketpalu aniketpalu requested a review from a team as a code owner October 21, 2025 12:22
Copy link
Member

@ntkathole ntkathole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ntkathole ntkathole merged commit 949ba3d into feast-dev:master Oct 23, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants