Fix #889 (wrong color to play) #890
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Ideally, we should support PL property in SGF to specify who to play if there are both black and white stones in the initial setup. See also Katrain's smarter way. sanderland/katrain#293 |
kaorahi
pushed a commit
to kaorahi/lizzie
that referenced
this pull request
Aug 26, 2021
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Caution: You also need to apply #766 to handle initial stones correctly in Lizzie 0.7.4.)
This patch fixes both #889 and another issue (handicap stones are not cleared for background engines) in Lizzie 0.7.3:
(;AB[dd]).The board is empty at 6, but no candidate appears around the top left corner.
Notes
This patch is just a workaround. It will be better to specify
playerexplicitly inlz-analyzelikelz-analyze b 10instead oflz-analyze 10. I did not do it this time because I am not sure whetherLizzie.board.getData().blackToPlay(orLizzie.board.getHistory().isBlacksTurn()) is always updated correctly before pondering.