Skip to content

Show change of winrate bar#897

Open
kaorahi wants to merge 2 commits intofeaturecat:masterfrom
kaorahi:wrbar_diff
Open

Show change of winrate bar#897
kaorahi wants to merge 2 commits intofeaturecat:masterfrom
kaorahi:wrbar_diff

Conversation

@kaorahi
Copy link
Copy Markdown
Contributor

@kaorahi kaorahi commented Sep 3, 2021

This patch imports one of my favorite features from LizGoban. The change of the winrate bar is shown as the green (= good move) or red (= bad move) rectangle.

Are there more suitable colors for Lizzie?

wrbar_diff

@hope366
Copy link
Copy Markdown

hope366 commented Sep 3, 2021

I think it's an interesting feature.
The win rate bar of lizzie will be displayed when Nihon Ki-in broadcasts live on youtube, but I think that viewers can enjoy it more by using the version with this function.

I would just like to mention one question that I have.
The image you attached shows a red rectangle to indicate how bad a move White made, but because it is on top of the black bar, it seems to intuitively recognize that Black made a bad move.

@kaorahi
Copy link
Copy Markdown
Contributor Author

kaorahi commented Sep 6, 2021

better ideas are welcome :)

@kaorahi
Copy link
Copy Markdown
Contributor Author

kaorahi commented Sep 8, 2021

As the above design seems to confuse some users, I modified it so that Lizzie shows just the previous winrate with a simple gray line. I expect this will not disturb your eyes.
wrbar_diff2

kaorahi pushed a commit to kaorahi/lizzie that referenced this pull request Sep 12, 2021
@kaorahi kaorahi mentioned this pull request Sep 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants