This repository has been archived by the owner on Aug 9, 2024. It is now read-only.
[WIP] Add tests for EC2ImageUploader #78
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sayanchowdhury
force-pushed
the
feature/add-tests-in-fedimg
branch
from
e6ab72c to
800c65a
Compare
euank
suggested changes
Apr 9, 2018
| image_id, | ||
| delete_snapshot=delete_snapshot | ||
| ) | ||
| # self._connect().deregister_image( |
There was a problem hiding this comment.
Please delete this code rather than leaving it commented out. We can always find it in git's history.
There was a problem hiding this comment.
Yes! I added the WIP tag to this PR. I need to do a few more changes to this PR
| @@ -200,7 +202,8 @@ def _register_image(self, snapshot): | |||
| virtualization_type=self.image_virtualization_type, | |||
| architecture=self.image_architecture, | |||
| block_device_mapping=block_device_map, | |||
| root_device_name=root_device_name | |||
| root_device_name=root_device_name, | |||
| ena_support=True | |||
There was a problem hiding this comment.
I believe my previous comment here still applies.
sayanchowdhury
changed the title
Signed-off-by: Sayan Chowdhury <[email protected]>
sayanchowdhury
force-pushed
the
feature/add-tests-in-fedimg
branch
from
48879d5 to
5e1c9f1
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.