Skip to content

<iframe> tag must have closing tag #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 2, 2025
Merged

<iframe> tag must have closing tag #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0aee4d0
<iframe> tag must have closing tag
qykth-git Sep 25, 2025
7af4b51
Restore original test code that works without closing tag
qykth-git Sep 29, 2025
0f705cf
lxml 6 no more drops control characters while parsing HTML input
qykth-git Sep 30, 2025
d5f935c
lxml 6.0.0 removes support for Python < 3.8
qykth-git Sep 30, 2025
af5e41b
Drop py36 from Github workflow
qykth-git Sep 30, 2025
1f767cd
Revert "Install build dependencies for Python 3.6"
qykth-git Oct 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,9 @@ jobs:
uses: fedora-python/tox-github-action@main
with:
tox_env: ${{ matrix.tox_env }}
dnf_install: gcc libxml2-devel libxslt-devel
strategy:
matrix:
tox_env:
- py36
- py38
- py39
- py310
Expand Down
6 changes: 3 additions & 3 deletions tests/test_clean.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,20 +331,20 @@ def test_host_whitelist_slash_type_confusion(self):

def test_host_whitelist_valid(self):
# Frame with valid hostname in src is allowed.
html = '<div><iframe src="https://example.com/page"></div>'
html = '<div><iframe src="https://example.com/page"></iframe></div>'
expected = '<div><iframe src="https://example.com/page"></iframe></div>'
cleaner = Cleaner(frames=False, host_whitelist=["example.com"])
self.assertEqual(expected, cleaner.clean_html(html))

def test_host_whitelist_invalid(self):
html = '<div><iframe src="https://evil.com/page"></div>'
html = '<div><iframe src="https://evil.com/page"></iframe></div>'
expected = '<div></div>'
cleaner = Cleaner(frames=False, host_whitelist=["example.com"])
self.assertEqual(expected, cleaner.clean_html(html))

def test_host_whitelist_sneaky_userinfo(self):
# Regression test: Don't be fooled by hostname and colon in userinfo.
html = '<div><iframe src="https://example.com:@evil.com/page"></div>'
html = '<div><iframe src="https://example.com:@evil.com/page"></iframe></div>'
expected = '<div></div>'
cleaner = Cleaner(frames=False, host_whitelist=["example.com"])
self.assertEqual(expected, cleaner.clean_html(html))
Expand Down
2 changes: 1 addition & 1 deletion tests/test_clean.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@
<body onload="evil_function()">
<!-- I am interpreted for EVIL! -->
<a href="javascript:evil_function()">a link</a>
<a href="javascrip%20t%20:evil_function()">a control char link</a>
<a href="j%01a%02v%03a%04s%05c%06r%07i%0Ep%20t%20:evil_function()">a control char link</a>
<a href="data:text/html;base64,PHNjcmlwdD5hbGVydCgidGVzdCIpOzwvc2NyaXB0Pg==">data</a>
<a href="#" onclick="evil_function()">another link</a>
<p onclick="evil_function()">a paragraph</p>
Expand Down
2 changes: 1 addition & 1 deletion tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[tox]
envlist = py36,py38,py39,py310,py311,py312,py313,mypy
envlist = py38,py39,py310,py311,py312,py313,mypy
skipsdist = True

[testenv]
Expand Down